Fix terrain rendering incorrectly when far from origin #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #422. |
3 tasks
mitchej123
approved these changes
Dec 13, 2024
|
This broke rendering for most AE2 blocks (smart cables, interfaces, etc). They're getting rendered in the wrong location, I assume they have some custom rendering that assumes world space coordinates but haven't looked into it at all. I noticed this when I was testing our PRs today.
|
|
Pain. Thanks for flagging that. |
embeddedt
added a commit
that referenced
this pull request
Dec 16, 2024
This reverts commit df66218.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce, teleport to a far-away coordinate on one dimension (e.g.
16777216 70 320). Blocks will start to render inaccurately. This is caused byRenderBlocksbeing given the world-space coordinates for block rendering, while usingfloats internally. The fix is to giveRenderBlockssubchunk-relative coordinates and a fakeIBlockAccessthat translates back to world-relative coordinates that the rest of the modernized Angelica stack expects.