Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(game): legacy commands for stats #236

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

feat(game): legacy commands for stats #236

wants to merge 25 commits into from

Conversation

MeikelLP
Copy link
Owner

@MeikelLP MeikelLP commented Nov 26, 2024 •
edited
Loading

see #100

Implemented:

  • /set [Target] gold [Value]
  • /set [Target] exp [Value]
  • /set_maxhp [Value]
  • /set_maxsp [Value]
  • /setskillother [Target] [Skill] [Value]
  • /setskill [Skill] [Value]
  • /setskillpoint [Skill] [Value]
  • /all_skills_master
  • /con+
  • /int+
  • /str+
  • /dex+
  • /mspd
  • /stat_reset
  • /full_set
  • /purge
  • /state
  • /mm
  • /group
  • /grrandom
  • /gstate
  • /purge

Additional changes

  • Implemented EPlayerClassGendered to avoid magic numbers
  • Fix equipping of shields
  • Improved display of command line validation errors

TODO

  • fix /set [Target] exp [Value] when no exp.csv exists
  • fix /setskillother [Target] [Skill] [Value] - Not an issue /setskillother Admin 19 14 works fine

@MeikelLP MeikelLP added type/feature New content area/game The game app is affected labels Nov 26, 2024
@MeikelLP MeikelLP added this to the 0.1 The Baseline milestone Nov 26, 2024
@MeikelLP MeikelLP requested a review from Jafah November 26, 2024 19:56
@MeikelLP MeikelLP mentioned this pull request Nov 26, 2024
Open
42 tasks
@Arichikurumo
Copy link

Arichikurumo commented Nov 28, 2024 •
edited
Loading

tested:

  • /set [Target] gold [Value]
  • /set [Target] exp [Value] -> crashed if you do not have exp.csv
  • /set_maxhp [Value]
  • /set_maxsp [Value]
  • /setskill /setskillpoint
  • /all_skills_master
  • /con+
  • /int+
  • /str+
  • /dex+
  • /mspd -> Command validation failed if speed > 255
  • /stat_reset
  • /full_set

not tested:
/set [Target] align [Value]
/setskillother

@MeikelLP
Copy link
Owner Author

@all-contributors add @Arichikurumo for testing

@allcontributors allcontributors bot mentioned this pull request Nov 28, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@MeikelLP

I've put up a pull request to add @Arichikurumo! 🎉

@MeikelLP MeikelLP mentioned this pull request Dec 6, 2024
Open
@MeikelLP MeikelLP self-assigned this Dec 6, 2024
@MeikelLP MeikelLP assigned Arichikurumo and unassigned MeikelLP Dec 13, 2024
@MeikelLP MeikelLP added the help wanted Extra attention is needed label Dec 17, 2024
@MeikelLP
Merge branch 'master' into feature/set-command
d98ec45 
# Conflicts:
#	src/Game.Benchmarks/Benchmarks/WorldUpdateBenchmark.cs
#	src/Libraries/Game.Server/IPlayerManager.cs
#	src/Libraries/Game.Server/World/Map.cs
#	src/Tests/Game.Tests/CommandTests.cs
#	src/Tests/Game.Tests/WorldTests.cs
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jafah Jafah Awaiting requested review from Jafah

At least 1 approving review is required to merge this pull request.

Assignees

@Arichikurumo Arichikurumo

Labels
area/game The game app is affected help wanted Extra attention is needed type/feature New content
Projects
None yet
Milestone
0.1 The Baseline
Development

Successfully merging this pull request may close these issues.
2 participants
@MeikelLP @Arichikurumo