Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review: Web Notification #3186

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: David Risney <[email protected]>
  • Loading branch information
peiche-jessica and david-risney authored Dec 13, 2022
commit 952a757064a5fe7256e5ad17c87504975477ee04
8 changes: 4 additions & 4 deletions specs/WebNotification.md
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ interface ICoreWebView2NotificationReceivedEventArgs : IUnknown {
///
/// The caller must free the returned string with `CoTaskMemFree`. See
/// [API Conventions](/microsoft-edge/webview2/concepts/win32-api-conventions#strings).
[propget] HRESULT Uri([out, retval] LPWSTR* uri);
[propget] HRESULT Uri([out, retval] LPWSTR* value);

/// The notification that was received. End developers can access the
/// properties on the Notification object to show their own notification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar. "You can access" to show "their own notification".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix.

Expand All @@ -342,10 +342,10 @@ interface ICoreWebView2NotificationReceivedEventArgs : IUnknown {
///
/// If `Handled` is set to TRUE then WebView will not display the notification
/// with the default UI, and the host will be responsible for handling the
/// notification and let the web content know that the notification has been
/// notification and for letting the web content know that the notification has been
/// displayed, clicked, or closed. If after the event handler or deferral
/// completes `Handled` is set to FALSE then WebView will display the default
/// notification. Note that if `Show` has been called on the `Notification`
/// notification UI. Note that if `Show` has been called on the `Notification`
/// object, WebView will not display the default notification regardless of
/// the Handled property. The default value is FALSE.
[propput] HRESULT Handled([in] BOOL value);
Expand Down Expand Up @@ -478,7 +478,7 @@ interface ICoreWebView2Notification : IUnknown {
///
/// The caller must free the returned string with `CoTaskMemFree`. See
/// [API Conventions](/microsoft-edge/webview2/concepts/win32-api-conventions#strings).
[propget] HRESULT Title ([out, retval] LPWSTR* title);
[propget] HRESULT Title([out, retval] LPWSTR* title);


/// The actions available for users to choose from for interacting with the
Expand Down