Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Review: Web Notification #3186

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

API Review: Web Notification #3186

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1c1d3d0
Add Web Notification API Spec draft
peiche-jessica Dec 9, 2022
952a757
Apply suggestions from code review
peiche-jessica Dec 13, 2022
e03a214
Address initial feedback part 1
peiche-jessica Dec 13, 2022
cbd9d61
Add enum CoreWebView2TextDirectionKinds to c# API details
peiche-jessica Dec 13, 2022
5e22e5f
Report* and CloseRequested
peiche-jessica Jan 4, 2023
0b9a618
Persistent -> ProfileNotificationReceivedEventHandler
peiche-jessica Jan 6, 2023
61d7ae7
Address initial feedback part 2
peiche-jessica Jan 6, 2023
c61f653
Update ref doc
peiche-jessica Jan 6, 2023
b8395cb
Add DataAsJson and TryGetDataAsString
peiche-jessica Jan 9, 2023
88418d0
Add links to Notification.actions
peiche-jessica Jan 9, 2023
0b6a3aa
Apply API name suggestion
peiche-jessica Jan 10, 2023
25207b4
Clarify Handled and ReportXXX methods
peiche-jessica Jan 10, 2023
8ef88d3
Clarify deferral info
peiche-jessica Jan 10, 2023
4908aaf
Fix sample code
peiche-jessica Jan 10, 2023
993fe9f
Make ReportClicked and ReportClosed async
peiche-jessica Jan 10, 2023
320baf0
Address feedback
peiche-jessica Feb 1, 2023
16ba2bc
Update sample
peiche-jessica Feb 3, 2023
4493c00
Merge pull request #3049 from MicrosoftEdge/api-notification-draft
peiche-jessica Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add enum CoreWebView2TextDirectionKinds to c# API details
  • Loading branch information
@peiche-jessica
peiche-jessica committed Dec 13, 2022
commit cbd9d614b9340e2cd267e58cd01f4922823eb019
8 changes: 6 additions & 2 deletions specs/WebNotification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,8 +541,12 @@ interface ICoreWebView2Notification : IUnknown {
```csharp
namespace Microsoft.Web.WebView2.Core
{
runtimeclass CoreWebView2NotificationReceivedEventArgs;
runtimeclass CoreWebView2Notification;
enum CoreWebView2TextDirectionKinds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Default" means the webview has a reasonable (probably correct) direction to apply for most cases, right?

Windows.UI.Core CoreWindowFlowDirection and Windows.UI.Xaml FlowDirection don't have "default", just the rtl+ltr values, but I think including Default makes sense here since most users of the enum won't care to be specifying this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure ref docs for this (above) correctly document this.

Also rename 'Default' to 'Auto'.

{
Default = 0,
LeftToRight = 1,
RightToLeft = 2,
};
runtimeclass CoreWebView2NotificationAction
{
// ICoreWebView2NotificationAction members
Expand Down