Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] sign_oca: Migration to 17.0 #33

Closed
wants to merge 60 commits into from
Closed

[17.0][MIG] sign_oca: Migration to 17.0 #33

wants to merge 60 commits into from

Conversation

peluko00
Copy link

No description provided.

@peluko00 peluko00 mentioned this pull request May 17, 2024
Open
2 tasks
@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch 2 times, most recently from e474b2e to 6a80cf0 Compare May 17, 2024 13:45
@pedrobaeza
Copy link
Member

/ocabot migration sign_oca

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 17, 2024
@pedrobaeza
Copy link
Member

Please include #22

@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch 2 times, most recently from ed84465 to dbbba01 Compare May 17, 2024 14:56
etobella and others added 22 commits May 17, 2024 16:59
@etobella @peluko00
[ADD] sign_oca
4ce0c57
@peluko00
[UPD] Update sign_oca.pot
a5ef751
@mariadforgeflow @peluko00
[FIX] sign_oca: wizard_id comodel
209437f
@OCA-git-bot @peluko00
[BOT] post-merge updates
2c642c4
@etobella @peluko00
[FIX] sign_oca: black, isort, prettier
65abdb4
@etobella @peluko00
[MIG] sign_oca: Migration to 16.0
cf90c3f
@peluko00
[UPD] Update sign_oca.pot
e74e673
@mymage @peluko00
Added translation using Weblate (Italian)
037a1c0
@mymage @peluko00
Translated using Weblate (Italian)
1bac44c 
Currently translated at 28.2% (48 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
@mymage @peluko00
Translated using Weblate (Italian)
16fd7e4 
Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
@etobella @peluko00
[FIX] sign_oca: Add description sign.oca.request.log
46ee2fc
@etobella @peluko00
[FIX] sign_oca: oe_chatter should not be added on non mail.thread models
04d7362
@peluko00
[UPD] Update sign_oca.pot
b7d0e92
@OCA-git-bot @peluko00
[BOT] post-merge updates
a0809a7
@weblate @peluko00
Update translation files
d3f0267 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
@mymage @peluko00
Translated using Weblate (Italian)
aa239b2 
Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
@mymage @peluko00
Translated using Weblate (Italian)
1a00973 
Currently translated at 100.0% (170 of 170 strings)

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
@victoralmau @peluko00
[FIX] sign_oca: Add configure action to sign.oca.request.log
62e620a 
TT41745
@victoralmau @peluko00
[FIX] sign_oca: Add filename file to show binary correctly in UX
aba636c 
TT41745
@victoralmau @peluko00
[IMP] sign_oca: Change t-raw to t-out
f5021b5
@peluko00
[UPD] Update sign_oca.pot
d4ff97c
@OCA-git-bot @peluko00
[BOT] post-merge updates
14cce87
PauBForgeFlow and others added 5 commits May 17, 2024 16:59
@PauBForgeFlow @peluko00
[IMP] sign_oca: Add pre_migration script
f54c5ae 
Change partner_type column to partner_selection_policy
@peluko00
[UPD] Update sign_oca.pot
56daa61
@OCA-git-bot @peluko00
[BOT] post-merge updates
e3da38a
@weblate @peluko00
Update translation files
86dca08 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sign-16.0/sign-16.0-sign_oca
Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
@peluko00
[IMP] sign_oca: pre-commit auto fixes
ef43b4d
@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch from dbbba01 to ef43b4d Compare May 17, 2024 15:05
@victoralmau
Copy link
Member

Please, include #28 + #39

@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch from a33d59b to b2537a2 Compare May 23, 2024 06:20
@peluko00
Copy link
Author

Please, include #28 + #39

Done, thanks!

@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch from b2537a2 to 7c14a79 Compare May 23, 2024 08:52
@victoralmau
Copy link
Member

Please, include #42

Sorry, I want to review this PR today or tomorrow

victoralmau
victoralmau suggested changes May 24, 2024
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review seems to be correct but I have not been able to test it functionally (when I go to runboat and try to log in it gives an error because it seems it is not adapted to owl correctly).

@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch from 7c14a79 to 0af3982 Compare May 27, 2024 05:59
@peluko00
Copy link
Author

Please, include #42

Sorry, I want to review this PR today or tomorrow

Done, thanks!

@peluko00
Copy link
Author

Code review seems to be correct but I have not been able to test it functionally (when I go to runboat and try to log in it gives an error because it seems it is not adapted to owl correctly).

Not really yet, i need to revise how to replace the registerModel function in v17. Any idea?

@victoralmau
Copy link
Member

Not really yet, i need to revise how to replace the registerModel function in v17. Any idea?

Sorry, I don't know exactly what the right way would be in this case, although there are probably examples in core modules that can help you.

@victoralmau
Copy link
Member

Please, include #41 + #45

@peluko00 peluko00 force-pushed the 17.0-mig-sign_oca branch 4 times, most recently from 4252ed1 to 47a40a4 Compare June 4, 2024 07:24
@victoralmau
Copy link
Member

Please, include #63

@peluko00
[MIG] sign_oca: Migration to 17.0
fe8344e 
>
>
Co-authored-by: Bernat Puig <[email protected]>
@victoralmau
Copy link
Member

Before reviewing it I see that you have included the changes in the migration commit instead of cherry-picking the corresponding commits and adding it before the v17 migration commit. Can you change it?

@flotho
Copy link
Member

flotho commented Sep 18, 2024

Tried to install on a local database and have this issue :
image

nothing special in the server logs.
In the browser I have :

Caused by: TypeError: Comp1 is undefined
    slot2@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js line 1503 > Function:21:72
    callSlot@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1109:25
    template@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js line 1503 > Function:8:12
    _render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:940:96
    render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:939:6
    initiateRender@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1007:47
    async*createComponent/<@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1543:80
    template@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js line 1503 > Function:58:24
    _render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:940:96
    render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:939:6
    initiateRender@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1007:47
    async*createComponent/<@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1543:80
    template@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js line 1503 > Function:12:12
    _render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:940:96
    render@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:939:6
    initiateRender@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1007:47
    async*mountComponent@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1003:120
    mountNode@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1529:20
    mount@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1525:64
    mountComponent@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:1582:207
    async*startWebClient@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:18781:740
    async*@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:18778:226
    startModule@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:11:159
    startModules@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:10:57
    addJob@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:7:39
    define@http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:6:141
    @http://localhost:8069/web/assets/500d77e/web.assets_web.min.js:18781:6

impossible to find this Comp1 in the base code.

@victoralmau
Copy link
Member

Please, include #69

@victoralmau victoralmau mentioned this pull request Oct 31, 2024
Merged
@victoralmau
Copy link
Member

victoralmau commented Oct 31, 2024 •
edited by pedrobaeza
Loading

Superseded by #70

@pedrobaeza pedrobaeza closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.