Tags: Pengchengxiang/hermes
Tags
Enable the debugger by default in host builds Summary: Always enable the Hermes debugger in host builds to decrease the number of supported configurations. Reviewed By: willholen Differential Revision: D20969039 fbshipit-source-id: 2ab5cb3aa5abf911ae60d20f0b8eb30bc04a3b3a
make deleted function public (facebook#30) Summary: This apparently gives better compiler error messages. Pull Request resolved: facebookincubator/fbjni#30 Test Plan: CI Reviewed By: mhorowitz Differential Revision: D19396160 Pulled By: dreiss fbshipit-source-id: 8e86d8c684be81bc74b03bfc58d71f5c21dac095
Make sure MSVC++ redistributable DLLs become part of the release Summary: msvcp140.dll and vcruntime140.dll were not being included in the release due to the package.json. These are required for the Windows binaries. Reviewed By: mhorowitz Differential Revision: D18412036 fbshipit-source-id: d09e9f714390bdef28333c6a5047fdc5952010f6
Make OSS libhermes ABI compatible with RN Summary: We removed a method that RN currently uses, which means that Hermes 0.2.x can not be used with RN <=0.60.5. See facebook#109 This diff adds a dummy passthrough method for linking compatibility. Reviewed By: mhorowitz Differential Revision: D17351288 fbshipit-source-id: 7d98af7065064dd47f66dba9ca82ac1192dff133
Clean up unused createStoreOwnPropertyInst Summary: We have 4 diferent versions of createStoreOwnPropertyInst, defined in different places in IRBuilder.h. Only 2 are used and one of them only has one occurance. Those definitions seem unnecessary to me and only increase the complexity of the API. Clean them up Reviewed By: dulinriley Differential Revision: D16496423 fbshipit-source-id: 0eba772aac774921d4fcd4463cdfa5f96db4ea83
Remove const_cast in createSnapshotFromFile wrapper. Summary: The function is not annotated with `const` so `plain()` will return a non-const reference to the undecorated Runtime already. Seems like the const_cast was a hold-over from a previous iteration. Reviewed By: mhorowitz Differential Revision: D16016320 fbshipit-source-id: 3dfa1e9acf2fc5c1ad61c9a8cd27c3c2e42036d3
Use correct name for stdin in source map Summary: When running the Hermes compiler driver with `-output-source-map` `-emit-binary` and read input from stdin rather than a file, we currently hit an assertion failure because we initialise the list of sources to `{"-"}` but add mappings that refrence `"<stdin>"`. This diff fixes that. Reviewed By: tmikov Differential Revision: D14995739 fbshipit-source-id: c9659e36406d55df543e2c36d993b10a66e045ed
remove memory allocation in signal handler Summary: Context: `ModuleIdManager` is introduced in SamplingProfiler to hold RuntimeModule alive with reference counting. With the new domain design, it is not necessary, holding strong references to Domain is enough. However, pushing a Domain into vector may cause memory allocation in signal handler causing potential deadlock/crash. To solve this, two new methods `increaseDomainCount/decreaseDomainCount` are added to perform `domains_` storage management outside of signal handler. To summarize, this diff does: * Remove `ModuleIdManager` and directly use RuntimeModule pointers in stack frame. * Introduce `increaseDomainCount/decreaseDomainCount` to manage `domains_` storage to avoid memory allocation in signal handler. * Added a new testcase Reviewed By: davedets Differential Revision: D15002859 fbshipit-source-id: 39460898a5acaa36cca772019c38d6871507b30c