Strict mode all the things.

RajaRamesh · Apr 8, 2015 · 69e63c2 · 69e63c2
1 parent e8ba1a1
commit 69e63c2
Show file tree

Hide file tree

Showing 510 changed files with 3,001 additions and 3,619 deletions.
diff --git a/js/.jshintrc b/js/.jshintrc
@@ -4,10 +4,12 @@
   "eqeqeq": true,
   "forin": true,
   "freeze": true,
+  "globalstrict": true,
   "immed": true,
   "laxbreak": true,
   "newcap": true,
   "noarg": true,
+  "node": true,
   "noempty": true,
   "nonbsp": true,
   "nonew": true,

diff --git a/js/actions/_admin/app.js b/js/actions/_admin/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/_admin/database/app.js b/js/actions/_admin/database/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/_admin/routing/app.js b/js/actions/_admin/routing/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/_admin/server/app.js b/js/actions/_admin/server/app.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, ArangoServerState */
+/*global ArangoServerState */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/_admin/wal/app.js b/js/actions/_admin/wal/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/_api/collection/app.js b/js/actions/_api/collection/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief querying and managing collections

diff --git a/js/actions/_api/foxx/app.js b/js/actions/_api/foxx/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief foxx administration actions

diff --git a/js/actions/_api/user/app.js b/js/actions/_api/user/app.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief user management

diff --git a/js/actions/api-aqlfunction.js b/js/actions/api-aqlfunction.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief AQL user functions management

diff --git a/js/actions/api-cluster.js b/js/actions/api-cluster.js
@@ -1,5 +1,5 @@
 /*jshint strict: false, unused: false */
-/*global require, AQL_EXECUTE, SYS_CLUSTER_TEST, UPGRADE_ARGS: true,
+/*global AQL_EXECUTE, SYS_CLUSTER_TEST, UPGRADE_ARGS: true,
   ArangoServerState, ArangoClusterComm, ArangoClusterInfo */
 
 ////////////////////////////////////////////////////////////////////////////////

diff --git a/js/actions/api-configuration.js b/js/actions/api-configuration.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief global configuration

diff --git a/js/actions/api-database.js b/js/actions/api-database.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, ArangoAgency */
+/*global ArangoAgency */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief database management

diff --git a/js/actions/api-edges.js b/js/actions/api-edges.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief managing edges

diff --git a/js/actions/api-endpoint.js b/js/actions/api-endpoint.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief endpoint management

diff --git a/js/actions/api-explain.js b/js/actions/api-explain.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, AQL_EXPLAIN */
+/*global AQL_EXPLAIN */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief query explain actions

diff --git a/js/actions/api-graph.js b/js/actions/api-graph.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, AQL_EXECUTE */
+/*global AQL_EXECUTE */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief graph api

diff --git a/js/actions/api-index.js b/js/actions/api-index.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief querying and managing indexes

diff --git a/js/actions/api-open.js b/js/actions/api-open.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief open actions

diff --git a/js/actions/api-simple.js b/js/actions/api-simple.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, CREATE_CURSOR */
+/*global CREATE_CURSOR */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief simple queries

diff --git a/js/actions/api-structure.js b/js/actions/api-structure.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief querying and managing structures

diff --git a/js/actions/api-system.js b/js/actions/api-system.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief administration actions

diff --git a/js/actions/api-tasks.js b/js/actions/api-tasks.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief querying and managing collections

diff --git a/js/actions/api-transaction.js b/js/actions/api-transaction.js
@@ -1,5 +1,5 @@
 /*jshint strict: false */
-/*global require, TRANSACTION */
+/*global TRANSACTION */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief transaction actions

diff --git a/js/actions/api-traversal.js b/js/actions/api-traversal.js
@@ -1,5 +1,4 @@
 /*jshint strict: false */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief traversal actions

diff --git a/js/apps/system/_admin/aardvark/APP/aardvark.js b/js/apps/system/_admin/aardvark/APP/aardvark.js
@@ -1,5 +1,5 @@
 /*jshint globalstrict: true */
-/*global require, applicationContext*/
+/*global applicationContext*/
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief A Foxx.Controller to show all Foxx Applications

diff --git a/js/apps/system/_admin/aardvark/APP/cluster.js b/js/apps/system/_admin/aardvark/APP/cluster.js
@@ -1,4 +1,4 @@
-/*global require, applicationContext*/
+/*global applicationContext*/
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief A Foxx.Controller to show all Foxx Applications

diff --git a/js/apps/system/_admin/aardvark/APP/clusterFrontend/build/cluster.js b/js/apps/system/_admin/aardvark/APP/clusterFrontend/build/cluster.js
@@ -602,7 +602,7 @@ return returnVal;
   });
 }());
 
-/*global require, exports, Backbone, window */
+/*global Backbone, window */
 window.ClusterStatisticsCollection = Backbone.Collection.extend({
   model: window.Statistics,
 
@@ -1256,15 +1256,15 @@ window.StatisticsDescription = Backbone.Model.extend({
 
 /*jshint browser: true */
 /*jshint unused: false */
-/*global require, exports, Backbone, window */
+/*global Backbone, window */
 window.StatisticsCollection = Backbone.Collection.extend({
   model: window.Statistics,
   url: "/_admin/statistics"
 });
 
 /*jshint browser: true */
 /*jshint unused: false */
-/*global require, exports, window, Backbone, arangoDocumentModel, _, arangoHelper, $*/
+/*global window, Backbone, arangoDocumentModel, _, arangoHelper, $*/
 (function() {
   "use strict";
 
@@ -1727,7 +1727,7 @@ window.StatisticsCollection = Backbone.Collection.extend({
 
 /*jshint browser: true */
 /*jshint unused: false */
-/*global require, exports, Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
+/*global Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
 /*global document, console, Dygraph, _,templateEngine */
 
 (function () {
@@ -2902,7 +2902,7 @@ window.StatisticsCollection = Backbone.Collection.extend({
   });
 }());
 
-/*global require, _, Dygraph, window, document */
+/*global _, Dygraph, window, document */
 
 (function () {
   "use strict";
@@ -3196,7 +3196,7 @@ window.StatisticsCollection = Backbone.Collection.extend({
 
 /*jshint browser: true */
 /*jshint strict: false, unused: false */
-/*global require, exports, Backbone, window */
+/*global Backbone, window */
 window.StatisticsDescriptionCollection = Backbone.Collection.extend({
   model: window.StatisticsDescription,
   url: "/_admin/statistics-description",
@@ -3383,7 +3383,7 @@ window.StatisticsDescriptionCollection = Backbone.Collection.extend({
   });
 }());
 
-/*global require, exports, Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
+/*global Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
 /*global document, Dygraph, _,templateEngine */
 
 (function() {

diff --git a/...m/_admin/aardvark/APP/clusterFrontend/js/collections/arangoClusterStatisticsCollection.js b/...m/_admin/aardvark/APP/clusterFrontend/js/collections/arangoClusterStatisticsCollection.js
@@ -1,4 +1,4 @@
-/*global require, exports, Backbone, window */
+/*global Backbone, window */
 window.ClusterStatisticsCollection = Backbone.Collection.extend({
   model: window.Statistics,
 

diff --git a/js/apps/system/_admin/aardvark/APP/clusterFrontend/js/views/dbServerDashboardView.js b/js/apps/system/_admin/aardvark/APP/clusterFrontend/js/views/dbServerDashboardView.js
@@ -1,4 +1,4 @@
-/*global require, exports, Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
+/*global Backbone, EJS, $, flush, window, arangoHelper, nv, d3, localStorage*/
 /*global document, Dygraph, _,templateEngine */
 
 (function() {

diff --git a/js/apps/system/_admin/aardvark/APP/foxxTemplates.js b/js/apps/system/_admin/aardvark/APP/foxxTemplates.js
@@ -1,4 +1,4 @@
-/*global require, applicationContext*/
+/*global applicationContext*/
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief A Foxx.Controller to generate new FoxxApps

diff --git a/js/apps/system/_admin/aardvark/APP/foxxes.js b/js/apps/system/_admin/aardvark/APP/foxxes.js
@@ -1,4 +1,4 @@
-/*global require, applicationContext */
+/*global applicationContext */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief A Foxx.Controller to show all Foxx Applications

diff --git a/js/apps/system/_admin/aardvark/APP/frontend/js/bootstrap/errors.js b/js/apps/system/_admin/aardvark/APP/frontend/js/bootstrap/errors.js
@@ -1,12 +1,11 @@
 /*jshint maxlen: 240 */
-/*global require */
 
 ////////////////////////////////////////////////////////////////////////////////
 /// @brief auto-generated file generated from errors.dat
 ////////////////////////////////////////////////////////////////////////////////
 
 (function () {
-  "use strict";
+  'use strict';
   var internal = require("internal");
 
   internal.errors = {