Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve raycasting data retrieval #13

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

alek-kam-robotec-ai
Copy link
Collaborator

No description provided.

Copy link
Contributor

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍
I have left some comments to resolve.
Please update static/PipelineGraph.mmd also.

Code/Source/Lidar/PipelineGraph.cpp Outdated Show resolved Hide resolved
Code/Source/Lidar/PipelineGraph.cpp Outdated Show resolved Hide resolved
Code/Source/Lidar/LidarRaycaster.cpp Show resolved Hide resolved
Code/Source/Lidar/PipelineGraph.h Show resolved Hide resolved
Code/Source/Lidar/LidarRaycaster.cpp Outdated Show resolved Hide resolved
Code/Source/Lidar/PipelineGraph.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Please consider my suggestion

Code/Source/Lidar/PipelineGraph.h Outdated Show resolved Hide resolved
@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the improve_lidar_data_retrival branch from 0239e2a to 345faa8 Compare September 29, 2023 10:29
@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the improve_lidar_data_retrival branch from 345faa8 to c3b5b74 Compare September 29, 2023 11:42
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the improve_lidar_data_retrival branch from c3b5b74 to c61341b Compare September 29, 2023 12:07
@alek-kam-robotec-ai alek-kam-robotec-ai merged commit df30db1 into development Sep 29, 2023
@alek-kam-robotec-ai alek-kam-robotec-ai deleted the improve_lidar_data_retrival branch September 29, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants