Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lidar intensity data #33

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

alek-kam-robotec-ai
Copy link
Collaborator

@alek-kam-robotec-ai alek-kam-robotec-ai commented Jul 9, 2024

This pr aims to add intensity support. It also:

  • introduces wrapper classes for the native RGL Mesh, Entity and Texture pointers.
  • Changes Mesh Library to Model Library which now also stores texture data.
  • Adds intensity handling for both Mesh Components (based on their material) and terrain (based on globally set intensity texture (rgb or greyscale)) or a uniform intensity value.
  • Mesh triangles are now aligned with the ones generated by the Terrain Gem (below - before and after the fix).
    Triangles-before
    Triangles-after

Known limitations:

  • Textures obtained by processing Material Assets are not updated with every simulation reload. However, if a material component is modified so that it uses a different Material Asset (one that was not used before), this asset is then processed into a texture.
  • Reflectance is calculated only from the albedo texture maps. This is a simplification. To achieve better realism, more material properties should be included in calculations.
  • For now, only BC1 and BC4 formats are handled. Gamma corrected colors are not adjusted.
  • Actor component is currently not supported.

@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the feature/intensity_support branch from 57a71be to b91476b Compare July 9, 2024 07:16
@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the feature/intensity_support branch from bdbd019 to 196c365 Compare July 23, 2024 12:45
@alek-kam-robotec-ai alek-kam-robotec-ai marked this pull request as ready for review July 23, 2024 12:45
@alek-kam-robotec-ai alek-kam-robotec-ai changed the title Add support for Lidar intensity data [Do not merge] Add support for Lidar intensity data Jul 23, 2024
Code/Source/Entity/ActorEntityManager.h Outdated Show resolved Hide resolved
Code/Source/Wrappers/Mesh.cpp Outdated Show resolved Hide resolved
Code/Source/Wrappers/Entity.h Outdated Show resolved Hide resolved
Code/Source/Entity/MeshEntityManager.cpp Outdated Show resolved Hide resolved
Code/Source/Entity/Terrain/TerrainData.cpp Outdated Show resolved Hide resolved
Code/Source/Wrappers/Texture.h Outdated Show resolved Hide resolved
Code/Source/Wrappers/Texture.h Outdated Show resolved Hide resolved
Code/Source/Wrappers/Texture.cpp Outdated Show resolved Hide resolved
Code/Source/Wrappers/Texture.h Outdated Show resolved Hide resolved
Code/Source/Wrappers/Texture.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great updates! I responded to everything and put additional minor comments.

Code/Source/Wrappers/RglMesh.cpp Outdated Show resolved Hide resolved
Code/Source/Entity/Terrain/TerrainData.cpp Outdated Show resolved Hide resolved
Code/Source/Entity/Terrain/TerrainData.cpp Outdated Show resolved Hide resolved
Code/Source/Entity/Terrain/TerrainData.cpp Show resolved Hide resolved
Code/Include/RGL/SceneConfiguration.h Outdated Show resolved Hide resolved
Code/Source/Wrappers/RglTexture.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@msz-rai msz-rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! 👍

Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
Signed-off-by: Aleksander Kamiński <[email protected]>
@alek-kam-robotec-ai alek-kam-robotec-ai force-pushed the feature/intensity_support branch from e40b892 to 39ca246 Compare August 2, 2024 07:19
@alek-kam-robotec-ai
Copy link
Collaborator Author

I've rebased this branch.

@PawelLiberadzki PawelLiberadzki changed the title [Do not merge] Add support for Lidar intensity data Add support for Lidar intensity data Aug 2, 2024
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alek-kam-robotec-ai alek-kam-robotec-ai merged commit 6eafa18 into development Aug 7, 2024
@alek-kam-robotec-ai alek-kam-robotec-ai deleted the feature/intensity_support branch August 7, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants