Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event responsiveness #53

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Fix event responsiveness #53

merged 3 commits into from
Sep 30, 2024

Conversation

alek-kam-robotec-ai
Copy link
Collaborator

@alek-kam-robotec-ai alek-kam-robotec-ai commented Sep 13, 2024 •
edited
Loading

This pr aims to improve gem's responsiveness to various events related to managed entities.

Those events include:

@alek-kam-robotec-ai
Add model change support
94de9a6 
Signed-off-by: Aleksander Kamiński <[email protected]>
@alek-kam-robotec-ai
Add actor instance destruction handling
89203a9 
Signed-off-by: Aleksander Kamiński <[email protected]>
@alek-kam-robotec-ai alek-kam-robotec-ai marked this pull request as ready for review September 13, 2024 11:21
@alek-kam-robotec-ai
Remove Debug printing
493497b 
Signed-off-by: Aleksander Kamiński <[email protected]>
@alek-kam-robotec-ai alek-kam-robotec-ai linked an issue Sep 26, 2024 that may be closed by this pull request
OnModelReady assert fail when dynamically adding mesh to Entity. #23
Closed
PawelLiberadzki
PawelLiberadzki approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@PawelLiberadzki PawelLiberadzki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have also checked runtime and it works as expected.

@alek-kam-robotec-ai alek-kam-robotec-ai merged commit 7d7c251 into development Sep 30, 2024
@alek-kam-robotec-ai alek-kam-robotec-ai deleted the fix/event-responsiveness branch September 30, 2024 08:29
@alek-kam-robotec-ai alek-kam-robotec-ai mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PawelLiberadzki PawelLiberadzki PawelLiberadzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OnModelReady assert fail when dynamically adding mesh to Entity.
2 participants
@alek-kam-robotec-ai @PawelLiberadzki