cleanup

include/co/tcp.h

@@ -236,7 +236,7 @@ class __coapi Client final {
     const char* strerror() const;
 
     // get the socket fd 
-    int socket() const { return _fd; }
+    int socket() const { (void)_; return _fd; }
 
   private:
     union {
@@ -245,6 +245,7 @@ class __coapi Client final {
     };
     uint16 _port;
     uint8 _use_ssl;
+    uint8 _;
     int _fd;
 };
 

src/co/epoll/epoll.cc

@@ -144,7 +144,7 @@ void Epoll::handle_ev_pipe() {
             break;
         }
     }
-    atomic_store(&_signaled, 0, mo_relaxed);
+    atomic_store(&_signaled, 0, mo_release);
 }
 
 } // co

src/co/epoll/epoll.h

@@ -38,7 +38,7 @@ class Epoll {
 
     // write one byte to the pipe to wake up the epoll.
     void signal(char c = 'x') {
-        if (atomic_bool_cas(&_signaled, 0, 1, mo_relaxed, mo_relaxed)) {
+        if (atomic_bool_cas(&_signaled, 0, 1, mo_acq_rel, mo_acq_rel)) {
             const int r = (int) CO_RAW_API(write)(_pipe_fds[1], &c, 1);
             ELOG_IF(r != 1) << "pipe write error..";
         }

src/co/epoll/iocp.h

@@ -51,7 +51,7 @@ class Iocp {
     }
 
     void signal() {
-        if (atomic_compare_swap(&_signaled, 0, 1, mo_acquire, mo_acquire) == 0) {
+        if (atomic_bool_cas(&_signaled, 0, 1, mo_acquire, mo_acquire)) {
             const BOOL r = PostQueuedCompletionStatus(_iocp, 0, 0, 0);
             ELOG_IF(!r) << "PostQueuedCompletionStatus error: " << co::strerror();
         }

src/co/epoll/kqueue.cc

@@ -126,7 +126,7 @@ void Kqueue::handle_ev_pipe() {
             break;
         }
     }
-    atomic_store(&_signaled, 0, mo_relaxed);
+    atomic_store(&_signaled, 0, mo_release);
 }
 
 } // co

src/co/epoll/kqueue.h

@@ -37,7 +37,7 @@ class Kqueue {
     }
 
     void signal(char c = 'x') {
-        if (atomic_bool_cas(&_signaled, 0, 1, mo_relaxed, mo_relaxed)) {
+        if (atomic_bool_cas(&_signaled, 0, 1, mo_acq_rel, mo_acq_rel)) {
             const int r = (int) CO_RAW_API(write)(_pipe_fds[1], &c, 1);
             ELOG_IF(r != 1) << "pipe write error..";
         }