-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: make the legend open by default if opening a child layer #139
Conversation
Visit the preview URL for this PR (updated for commit 1edd871): https://ut-dnr-ugs-hazards-dev--pr139-legend-auto-open-ibo50i0n.web.app (expires Wed, 19 Feb 2025 22:41:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9b54b233c1d4b6253a0f3034cf20aba73f2a0d52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of opening the legend is that users can see the symbology immediately upon turning on a layer. I think we'll need to open the layer details accordion as well as the legend accordion to make that happen.
Also, do we want the layer details/legend accordions to close when the layer is turned off? That's what the current live hazards app does. I lean towards "yes" to save layerlist space.
- Make layer accordion close when layer is turned off
- BUG: only one info OR legend should be open at a time
Addressed those changes. Ready for review |
90ec1f8
to
1edd871
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be working fine! Nice job.
* fix: account for no dasharray property in the simplelinesybol * refactor: link to simplelinesymbol docs for style options * refactor: change basemap name, remove streets relief (#133) * refactor: convert all polygons to 75% opacity for map load (#134) * refactor: make navbar tooltip text color darker on light mode (#135) * feat: make popup content, pagination, and graphics reset (#136) * refactor: remove nav link to https://geology.utah.gov/, make logo clickable to redirect user (#137) * refactor: make the accordion open if the switch is checked by default (#138) * refactor: make the legend open by default if opening a child layer (#139) * refactor: make the legend open by default if opening a child layer * refactor: toggle the accordion with the checkbox * feat: add custom basemap option for the basemapList (#140) * feat: add custom basemap option for the basemapList
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.