feat: add custom basemap option for the basemapList #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clintonlunn
commented
Feb 13, 2025
clintonlunn
commented
|
Visit the preview URL for this PR (updated for commit 27771bc): https://ut-dnr-ugs-hazards-dev--pr140-topo-basemap-qxn2szq4.web.app (expires Wed, 19 Feb 2025 23:11:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9b54b233c1d4b6253a0f3034cf20aba73f2a0d52 |
There was a problem hiding this comment.
The basemap options look good.
There's some weird behavior when you select different basemaps. When you select an option on the header, they all get underlined and bolded. If you select one from the "more" drop down, those two get underlined and not the header. Can that be fixed with this ticket?
Mackenzie-Cope
approved these changes
Feb 13, 2025
Merged
clintonlunn
added a commit
that referenced
this pull request
Feb 13, 2025
* fix: account for no dasharray property in the simplelinesybol * refactor: link to simplelinesymbol docs for style options * refactor: change basemap name, remove streets relief (#133) * refactor: convert all polygons to 75% opacity for map load (#134) * refactor: make navbar tooltip text color darker on light mode (#135) * feat: make popup content, pagination, and graphics reset (#136) * refactor: remove nav link to https://geology.utah.gov/, make logo clickable to redirect user (#137) * refactor: make the accordion open if the switch is checked by default (#138) * refactor: make the legend open by default if opening a child layer (#139) * refactor: make the legend open by default if opening a child layer * refactor: toggle the accordion with the checkbox * feat: add custom basemap option for the basemapList (#140) * feat: add custom basemap option for the basemapList
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.