Skip to content

Commit

Permalink
MDL-74802 core: Remove tooltip on the notification close button
Browse files Browse the repository at this point in the history
Reverting the addition of a Boostrap tooltip on the alert notification's
close button. It introduced a bug where the tooltip remains after
dismissing the notification alert. We can manually toggle the state of
the tooltip via JS, but I don't think it's worth the effort. The tooltip
is meant as an added bonus for sighted users to see what the close
button is about.
  • Loading branch information
junpataleta authored and sarjona committed Jun 10, 2022
1 parent bfa2c03 commit 4bcd61f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions lib/templates/notification_base.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
}}{{# announce }} role="alert" data-aria-autofocus="true"{{/ announce }}>
{{{ message }}}
{{# closebutton }}{{!
}}<button type="button" class="close" data-dismiss="alert" title="{{#str}}dismissnotification, core{{/str}}"{{!
}} data-toggle="tooltip">
}}<button type="button" class="close" data-dismiss="alert">
<span aria-hidden="true">&times;</span>
<span class="sr-only">{{#str}}dismissnotification, core{{/str}}</span>
</button>{{!
Expand Down

0 comments on commit 4bcd61f

Please sign in to comment.