MDL-48934 navigation: Update the default entries in the user menu.

Add mypreferences and remove mybadges and myfiles (You should get to the
last 2 through your dashboard).

Part of MDL-45774

admin/settings/appearance.php

@@ -29,8 +29,7 @@
         new lang_string('configcustomusermenuitems', 'admin'),
         'mygrades,grades|/grade/report/mygrades.php|grades
 messages,message|/message/index.php|message
-myfiles,moodle|/user/files.php|download
-mybadges,badges|/badges/mybadges.php|award',
+mypreferences,moodle|/user/preferences.php|preferences',
         PARAM_TEXT,
         '50',
         '10'

lang/en/moodle.php

@@ -1216,6 +1216,7 @@
 $string['myhome'] = 'Dashboard';
 $string['mymoodledashboard'] = 'My Moodle dashboard';
 $string['myprofile'] = 'My profile';
+$string['mypreferences'] = 'My preferences';
 $string['name'] = 'Name';
 $string['nameforlink'] = 'What do you want to call this link?';
 $string['nameforpage'] = 'Name';

lib/db/upgrade.php

@@ -4306,11 +4306,36 @@ function xmldb_main_upgrade($oldversion) {
 
     if ($oldversion < 2015040800.01) {
         // Add "My grades" to the user menu.
-        $newconfig = "mygrades,grades|/grade/report/mygrades.php|grades\n" . $CFG->customusermenuitems;
-        set_config('customusermenuitems', $newconfig);
+        $oldconfig = get_config('core', 'customusermenuitems');
+        if (strpos("mygrades,grades|/grade/report/mygrades.php|grades", $oldconfig) === false) {
+            $newconfig = "mygrades,grades|/grade/report/mygrades.php|grades\n" . $CFG->customusermenuitems;
+            set_config('customusermenuitems', $newconfig);
+        }
 
         upgrade_main_savepoint(true, 2015040800.01);
     }
 
+    if ($oldversion < 2015030400.02) {
+        // Update the default user menu (add preferences, remove my files and my badges).
+        $oldconfig = get_config('core', 'customusermenuitems');
+
+        // Add "My preferences" at the end.
+        if (strpos($oldconfig, "mypreferences,moodle|/user/preference.php|preferences") === false) {
+            $newconfig = $oldconfig . "\nmypreferences,moodle|/user/preferences.php|preferences";
+        } else {
+            $newconfig = $oldconfig;
+        }
+        // Remove my files.
+        $newconfig = str_replace("myfiles,moodle|/user/files.php|download", "", $newconfig);
+        // Remove my badges.
+        $newconfig = str_replace("mybadges,badges|/badges/mybadges.php|award", "", $newconfig);
+        // Remove holes.
+        $newconfig = preg_replace('/\n+/', "\n", $newconfig);
+        $newconfig = preg_replace('/(\r\n)+/', "\n", $newconfig);
+        set_config('customusermenuitems', $newconfig);
+
+        upgrade_main_savepoint(true, 2015030400.02);
+    }
+
     return true;
 }