MDL-35155: Fix MSSQL bug in sql_substr()

UniGe · Dec 31, 2014 · e53364b · e53364b
1 parent eb1dc9f
commit e53364b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/dml/mssql_native_moodle_database.php b/lib/dml/mssql_native_moodle_database.php
@@ -1257,7 +1257,7 @@ public function sql_substr($expr, $start, $length=false) {
 s only returning name of SQL substring function, it now requires all parameters.');
         }
         if ($length === false) {
-            return "SUBSTRING($expr, $start, (LEN($expr) - $start + 1))";
+            return "SUBSTRING($expr, $start, LEN($expr))";
         } else {
             return "SUBSTRING($expr, $start, $length)";
         }

diff --git a/lib/dml/sqlsrv_native_moodle_database.php b/lib/dml/sqlsrv_native_moodle_database.php
@@ -1324,7 +1324,7 @@ public function sql_substr($expr, $start, $length = false) {
         }
 
         if ($length === false) {
-            return "SUBSTRING($expr, $start, (LEN($expr) - $start + 1))";
+            return "SUBSTRING($expr, $start, LEN($expr))";
         } else {
             return "SUBSTRING($expr, $start, $length)";
         }