Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Download module #5

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Conversation

axiomcura
Copy link
Member

@axiomcura axiomcura commented Dec 16, 2024

This PR introduces the first notebook module, which focuses exclusively on downloading metadata. Currently, the selected feature profiles are not yet uploaded to the targeted_fibrosis_drug_screen repository As a result, this module only downloads the metadata at this stage. Any updates regarding about the data in the repo will be updated here.

Additionally, a config_loader() function and a configuration file have been added. These additions aim to enhance the readability and transparency of the project by centralizing parameters, which will be used consistently throughout the project's subsequent development.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I left a few comments for your consideration. Please don't hesitate to let me know if you have any questions.

notebooks/config.yaml Show resolved Hide resolved
src/io_utils.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
notebooks/0.download-data/0.download-data.sh Show resolved Hide resolved
notebooks/0.download-data/0.download-data.sh Show resolved Hide resolved
notebooks/0.download-data/nbconverted/0.download-data.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/io_utils.py Outdated Show resolved Hide resolved
src/io_utils.py Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@axiomcura
Copy link
Member Author

Thanks for the review @d33bs now merging !

@axiomcura axiomcura merged commit 4adcb34 into WayScience:main Dec 18, 2024
@axiomcura axiomcura deleted the download-module branch December 18, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants