fix whitespace rule in importClause with 'as' statement (palantir#4249)

abierbaum · Nov 5, 2018 · ba0ed60 · ba0ed60
1 parent 0172fab
commit ba0ed60
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/rules/whitespaceRule.ts b/src/rules/whitespaceRule.ts
@@ -191,7 +191,7 @@ function walk(ctx: Lint.WalkContext<Options>) {
                                         checkForTrailingWhitespace(token.getFullStart());
                                     }
                                     if (idx === 0) {
-                                        const startPos = internalName.getStart() - 1;
+                                        const startPos = element.getStart() - 1;
                                         checkForTrailingWhitespace(startPos, startPos + 1);
                                     }
                                 }

diff --git a/test/rules/whitespace/all/test.ts.fix b/test/rules/whitespace/all/test.ts.fix
@@ -67,6 +67,8 @@ import { importB } from "libB";
 import { importC } from "libC";
 import moduleD, { importD } from "libD";
 import { importD, importE } from "libD";
+import { importF as F } from "libF";
+import { importF as F, importG as G } from "libF";
 
 import {
   importA,

diff --git a/test/rules/whitespace/all/test.ts.lint b/test/rules/whitespace/all/test.ts.lint
@@ -120,6 +120,13 @@ import moduleD, {importD}from "libD";
 import {importD, importE} from "libD";
         ~                    [missing whitespace]
                         ~    [missing whitespace]
+import {importF as F} from "libF";
+        ~                    [missing whitespace]
+                    ~    [missing whitespace]
+import {importF as F,importG as G} from "libF";
+        ~                             [missing whitespace]
+                     ~                [missing whitespace]
+                                 ~    [missing whitespace]
 
 import {
   importA,