Update project / maintenance #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbdy
commented
Apr 15, 2024
•
nbdy
commented
- Replaced setup.py with pyproject.toml
- Updated requirements.txt (opencv was not used)
- Renamed module from RealESRGAN (collides with original pypi project) to py-real-esrgan
- Moved main.py to real_esrgan/main.py and added arguments (scale, model path, input path, output path)
- Updated README.md
- Reformatted code / optimized imports
add arguments
optimize imports
jag-k
suggested changes
Sep 2, 2024
| ] | ||
| dependencies = [ | ||
| "numpy", | ||
| "opencv-python", |
There was a problem hiding this comment.
Why we need it?
I think you forgot to delete :)
Suggested change
| "opencv-python", |
There was a problem hiding this comment.
You are right, it is not imported anywhere. I missed that.
Comment on lines
1
to
4
| numpy | ||
| opencv-python | ||
| Pillow | ||
| torch>=1.7 | ||
| torchvision>=0.8.0 |
There was a problem hiding this comment.
And I think we can delete this file entirely 'cause we already use pyproject.toml for it
Suggested change
| numpy | |
| opencv-python | |
| Pillow | |
| torch>=1.7 | |
| torchvision>=0.8.0 |
There was a problem hiding this comment.
The reason I kept this file is that PyCharm prompts the user if there are any missing dependencies.
It was more a convenience for me. Generally we can remove it, yes.
|
If you don't intent to publish it to pypi or if you don't want anyone to publish their work using this library on pypi there is no need to rename the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.