Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project / maintenance #29

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update project / maintenance #29

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b92cdb0
replace setup.py with pyproject.toml
nbdy Apr 15, 2024
eacf55c
update requirements.txt
nbdy Apr 15, 2024
ddda4a8
create __main__.py from main.py
nbdy Apr 15, 2024
8a47e08
project name RealESRGAN -> real_esrgan
nbdy Apr 15, 2024
9cb743f
use full import path
nbdy Apr 15, 2024
da87d41
reformatting
nbdy Apr 15, 2024
39a11ab
update README.md
nbdy Apr 15, 2024
599e99d
rename project to py-real-esrgan so we can add it to pypi
nbdy Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update requirements.txt
  • Loading branch information
@nbdy
nbdy committed Apr 15, 2024
commit eacf55c28b6585e617195a1ea465ebbcf7414397
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
numpy
opencv-python
Pillow
torch>=1.7
torchvision>=0.8.0
Comment on lines 1 to 4
Copy link

@jag-k jag-k Sep 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I think we can delete this file entirely 'cause we already use pyproject.toml for it

Suggested change
numpy
opencv-python
Pillow
torch>=1.7
torchvision>=0.8.0

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I kept this file is that PyCharm prompts the user if there are any missing dependencies.
It was more a convenience for me. Generally we can remove it, yes.

Expand Down