Do not close any channels to avoid racy "send on closed channel" panics

[flyingmutant]

Example panic, happened after the eventsource was closed:

panic: runtime error: send on closed channel

goroutine 147858 [running]:
runtime.panic(0x465000, 0x77641e)
    /usr/local/Cellar/go/1.3.1/libexec/src/pkg/runtime/panic.c:279 +0xf5
github.com/sporttech/eventsource.func·001()
    /Users/mrbrbr/dev/go/src/github.com/sporttech/eventsource/consumer.go:73 +0x384

There is no need to close any channels — it does not impact the GC, but
is only a signal to receivers that no data will be following (see
here).

As nothing in this package listens to close() of any channel, simply
removing all close() calls both simplifies the code and avoids
unexpected panic()s.

[antage]

This problem is more complex it seems. Removing closes hides leaking goroutines but doesn't solve the problem. I'll think how to fix Close function to avoid panics and sending to closed channels.

I have created issue #17. We can discuss there.

[flyingmutant]

Oh, sorry — I somehow missed that newConsumer() starts a goroutine which does listen to closes of .in channel.

If we do close those in .Close() everything looks fine to me. What do you thing?

[antage]

Goroutine that started in newConsumer may send in staled closed channel (as your example).

[flyingmutant]

I was talking about doing this: cc08403