fix(gsea): fix margin too large error #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because of the severity of the error, this temporary fix will be pushed onto master, but will still work on addressing the core of this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the analyte set title for the GSEA plot is too long, it can create an error
figure margin too large. This was previously addressed for SVG files by shortening the title. HMDB features many pathways with long names that seemed to still break the SVG output, or it was able to create this problem for the PNG output. Because the GSEA plot is not an absolutely necessary output for the analysis, it should not create an error, but instead it should display a warning.Fix applied
The
plotEnrichmentPlotfunction content is surrounded in atryto prevent errors in this function from stopping the analysis.Further steps