crypto: qce - fix uaf on qce_ahash_register_one

Pointer base points to sub field of tmpl, it is dereferenced after tmpl is freed. Fix this by accessing base before free tmpl. Fixes: ec8f5d8 ("crypto: qce - Qualcomm crypto engine driver") Signed-off-by: Chengfeng Ye <[email protected]> Acked-by: Thara Gopinath <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
caleberi · Nov 20, 2021 · b4cb4d3 · b4cb4d3
1 parent 4a9dbd0
commit b4cb4d3
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/crypto/qce/sha.c b/drivers/crypto/qce/sha.c
@@ -498,8 +498,8 @@ static int qce_ahash_register_one(const struct qce_ahash_def *def,
 
 	ret = crypto_register_ahash(alg);
 	if (ret) {
-		kfree(tmpl);
 		dev_err(qce->dev, "%s registration failed\n", base->cra_name);
+		kfree(tmpl);
 		return ret;
 	}