Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3204] set optional flags on OIDC validator schema #4704

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

Sets the optionals for the JWT processed during the OIDC verifier flow.

  • Different providers give different fields for name, username, preferred_username, picture, etc
  • Handle these optionals so that folks can use Sign in with Apple

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • Create an Apple ID with developer access
  • Hook up a Sign in with Apple api key with provider url's
  • Set the configuration under Admin > Configure > Authentication > Login with OpenID Connect
  • Attempt to login/register with Apple via the new OIDC login button that is now available in stream
  • See that it works

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

  • Merge into develop

- already set in the existing optional fork
@nick-funk nick-funk requested review from tessalt and kabeaty November 28, 2024 16:54
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 734a768
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6748a04d50de77000896f88c

@nick-funk nick-funk changed the title set optional flags on OIDC validator schema [CORL-3203] set optional flags on OIDC validator schema Nov 28, 2024
@nick-funk nick-funk changed the title [CORL-3203] set optional flags on OIDC validator schema [CORL-3203/4] set optional flags on OIDC validator schema Nov 28, 2024
@nick-funk nick-funk changed the title [CORL-3203/4] set optional flags on OIDC validator schema [CORL-3204] set optional flags on OIDC validator schema Nov 28, 2024
@tessalt tessalt added this pull request to the merge queue Dec 2, 2024
@tessalt tessalt removed this pull request from the merge queue due to a manual request Dec 2, 2024
@tessalt tessalt merged commit d115303 into develop Dec 2, 2024
6 checks passed
@tessalt tessalt deleted the fix/CORL-3204-oidc-optionals branch December 2, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants