Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the get_transform analog to set_transform #264

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

add support for the get_transform analog to set_transform #264

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0c21a73
add support for getting the aggregated scale/transform for individual…
pattonw Dec 10, 2024
bd77cd9
Revert "formatting changes"
pattonw Dec 10, 2024
6a490ff
address ziwen's comments
pattonw Dec 10, 2024
fc31a10
black formatting changes
pattonw Dec 10, 2024
d13942c
update test_get_transform_image test name
pattonw Dec 11, 2024
67848bc
factor out retrieving the list of all applicable transforms and impro…
pattonw Dec 11, 2024
6fc5ad6
use get_effective_scale to simplify the scale property
pattonw Dec 11, 2024
d3a8b43
use the first array's path in `scale` property to get the highest res…
pattonw Dec 11, 2024
e3f6ea1
Separate test into 2, and cover cases where both the fov and image ha…
pattonw Dec 11, 2024
c96a0cc
Return effective scale and transform as simple lists of floats instea…
pattonw Dec 11, 2024
a502407
Return plain floats instead of numpy floats
pattonw Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update test_get_transform_image test name
  • Loading branch information
@pattonw
pattonw committed Dec 11, 2024
commit d13942ca67a2306baf9c1b6e418c749caf485ba4
2 changes: 1 addition & 1 deletion tests/ngff/test_ngff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ def test_set_transform_image(ch_shape_dtype, arr_name):
ch_shape_dtype=_channels_and_random_5d_shape_and_dtype(),
arr_name=short_alpha_numeric,
)
def test_get_transform_image(transforms, ch_shape_dtype, arr_name):
def test_get_effective_transforms_image(transforms, ch_shape_dtype, arr_name):
"""Test `iohub.ngff.Position.set_transform()`"""
ziw-liu marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Test `iohub.ngff.Position.set_transform()`"""
"""Test `iohub.ngff.Position.get_effective_scale()`"""

transform, expected_scale, expected_translate = transforms
channel_names, shape, dtype = ch_shape_dtype
Expand Down