Run tests with IPv6 address #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/sigh Travis doesn't support IPv6, internal tests don't support IPv4 😢 Will likely just disable the test internally. |
|
You can do a sniff of Travis and switch to ipv4 – seems reasonable. |
|
Good idea! updated PTAL |
kevmoo
approved these changes
Jul 26, 2017
|
Ugh, now the buildbots don't like using IPv6 |
nex3
reviewed
Sep 19, 2017
| server = await IOServer.bind(InternetAddress.LOOPBACK_IP_V4, 0); | ||
| var address = Platform.environment.containsKey('TRAVIS') | ||
| ? InternetAddress.LOOPBACK_IP_V4 | ||
| : InternetAddress.LOOPBACK_IP_V6; |
There was a problem hiding this comment.
Can you add a comment explaining why we're testing on IPv6 on Travis and only Travis?
There was a problem hiding this comment.
Sure. The chances that the git blame becomes at all difficult to find before the comment becomes a lie seems incredibly low but we can add one for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.