Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with IPv6 address #76

Merged
merged 2 commits into from
Jul 26, 2017
Merged

Run tests with IPv6 address #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ee0466
Run tests with IPv6 address
natebosch Jul 26, 2017
055b780
Use IPv4 on travis
natebosch Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: shelf
version: 0.6.8
version: 0.6.9-dev
author: Dart Team <[email protected]>
description: Web Server Middleware for Dart
homepage: https://github.com/dart-lang/shelf
Expand Down
5 changes: 4 additions & 1 deletion test/io_server_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ import 'test_util.dart';
void main() {
var server;
setUp(() async {
server = await IOServer.bind(InternetAddress.LOOPBACK_IP_V4, 0);
var address = Platform.environment.containsKey('TRAVIS')
? InternetAddress.LOOPBACK_IP_V4
: InternetAddress.LOOPBACK_IP_V6;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we're testing on IPv6 on Travis and only Travis?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. The chances that the git blame becomes at all difficult to find before the comment becomes a lie seems incredibly low but we can add one for now.

#89

server = await IOServer.bind(address, 0);
});

tearDown(() => server.close());
Expand Down