Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements #117

Closed
wants to merge 4 commits into from
Closed

Achievements #117

wants to merge 4 commits into from

Conversation

cosme12
Copy link
Contributor

@cosme12 cosme12 commented Jul 10, 2014

Well, here is the achievements idea finished. It works like this:

  1. Manager-Prufung has been limited to 32 tasks (like we already have). Now we can add more tasks without being displayed in this list.

  2. Achievement works the same way as the tutorial (exactly the same way). setTaskDone() to complete the task. Achievements go from id>30.

  3. Achievements are displayed on players profile. They are public, so anybody can see them. Under the medals there is a link to the achievements list (achievements.php).

  4. achievements.php is a copy of Manager-Prufung but only medals are displayed. (from id>30). Here you can find a list of the medals you "must" get.

  5. Achievements task shouldnt explain how to get the reward but its name. For example:

  • id= 31
  • shortName= money_record_1
  • task= We are rich!
    (the icon is a $ medal)
    This way you we set the setTaskDone() when the players club gets more than $300m. Hover the mouse over the medal will also display the "task" (We are rich!).
  1. Each .png file use the "id task" as its name. Example: 31.png

  2. Each task should have its own level. Easy, Intermediate and Hard. Example:

  • We are rich! requieres 300m
  • We have even more money! requires 600m

Note: We are rich! task is a just an ugly example :P

Well I think thats all. You should ask players now for ideas (force them to do something too! :D
Some pictures over here (note: I had to make a new medal since the one we had before was really similar to one in another game):

31 31.png The numbre under the medal represent the level (easy, intermediate, hard. So it should go from 1 to 3, not 8 as we have here).

new-2

DONT MISS THIS TEXT :P
Here is a bad example of task name. It will reveal how to exactly complete the task removing all fun. This picture belongs to the new achievements.php file. You will have to add some explanation about "achievements" in the top text and table size fix. While writting this I realize it starts couting from [3].

I tried to use as less new code as I could, just to avoid adding bugs. I tested most of it, but since I changed a few things while writting maybe I broke something.

new-3

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 10, 2014

If we compared to the first concept idea we had, I forgot:

<h1>Achivments</h1>

@ocram
Copy link
Contributor

ocram commented Jul 12, 2014

Great work! Thank you!

Is this tested, i.e. have you tested it with some new achievements on your local version?

  • (4) I would prefer to have only the single file managerPruefung.php that already exists. Then, instead of making a copy, the behaviour of that file could be modified with something like ?mode=achievements. Could you add this and remove the new file achievements.php?
  • (6) It would be better if the PNG images could use the shortName database field as it's more descriptive. Can you change this?
  • (7) For the icons, we have to use something that is really our own, and not copied from some other game, no matter how much it has been edited. What about this icon? http://thenounproject.com/term/laurel-wreath/14389/ The NounProject is a wonderful collection of icons with licenses that allow us to use them without any headache, just like FamFamfam.com does. The one that I linked is "Public Domain", i.e. we can use it without attribution and without requirements.

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 13, 2014

Ok, I have already improved everything here.

  • I added everything inside managerPruefung.php as you asked.
  • Added the shortName to .png files, now they are placed inside a new folder in /images/achievements/
  • Maybe I wasnt clear when I said I made a new medal. I meant it is complete new and belong to us. I used a "Public Domain" image as the laurel (you can find it over here: http://www.clipartpal.com/clipart_pd/education/laurals_10889.html) resized it and the FamFamfam icons. If you still dont like it, let me know so I can change it.
  • Fixed the table size, added the title, fixed a bug with the % complete bar (if you pay attention to the image I posted before you will notice there are 3 taks and it shows 20% insteed of 33%), changed "Display all achievements" with "Display my achievements" (now it only shows when looking at your own profile)

I will be testing it a little more just in case, but it seems its working.
NOTE: I need you to check a few things in order to create a few task (we can make more later, or users will give us ideas). Go to your database man_teams and check the highest "konto" over there ( that will help me to make a money award, with 3 levels, depending on the money you have). Another one could be a cake with the number depending on the number of years you have been playing (old players would love it)

Just let me know if you have any other suggestion. Here you have some images of everything working.

vacio
lleno

My profile with achievement:

yo_lleno

My profile empty

yo_vacio

Other member with achievement

otro_lleno

Other member empty

otro_vacio

This was referenced Jul 17, 2014
@ocram
Copy link
Contributor

ocram commented Jul 22, 2014

Superseded by #125

@ocram ocram closed this Jul 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants