-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Achievements v1.1 #125
base: master
Are you sure you want to change the base?
Achievements v1.1 #125
Conversation
In case you want to know if it is working, here you have the latest version of BM running on my free test server. http://www.ballmanager.tk/
Here you can see "Achievements v1.1" working online. Just open your profile and check it. |
Looks very good, thank you :) Your test server is great, so we can easily switch between I'll merge this in the next few days. Do I have to merge the old pull request (#117) as well (before) or is this new one a replacement? |
Nop, this is a brand new complete system. So, there is no need to add the old one. Yeah, in that server is where I break stuff :D Feel free to test anything you like but be carefull with in SQL injection because the server auto bans you (already happened to me haha, so I had to ask the provider to fix it). |
These ideas are great! :)
Localize is full of XSS attempts because some penetration testing has been done by hackers to make sure everything is secure :) Thanks for being attentive! You can check it here: http://security.localize.im/ |
I removed the number with the levels in awards because they look ugly. So i was planing on having 1 level per medal (also changing just 1 numbers is really repetitive). Yes, im still using that laurel. Old system isnt affected by achievements because we start working from id=31. We should change the |
Fixed |
I will rework this soon. Due to all the recent changes, this patch doesnt work anymore. Anyways you never liked the icons :P I will try to find a better way of adding this and send you a preview. |
Ok, here is it. Hope you like it.
Right now, only 2 achievements can be finished (I wanted to avoid to many files changes so you can give me your feedback). Everything is tested and working. There shouldnt be any problem or exploits.
INSERT INTO
man_licenseTasks
(id
,shortName
,task
) VALUES(NULL, 'graduated', 'Graduated'),
(NULL, 'happy_birthday', 'Happy Birthday'),
(NULL, 'im_so_popular', 'Im so popular'),
(NULL, 'climbing_the_ladder', 'Climbing the ladder'),
(NULL, 'perfect_score', 'Perfect Score'),
(NULL, 'poeple_adore_me', 'People adore me'),
(NULL, 'double_haat_trick', 'Double Hat-Trick'),
(NULL, 'new_home', 'New Home'),
(NULL, 'the_wall', 'The Wall'),
(NULL, 'invencible', 'Invencible'),
(NULL, 'spending_the_cash', 'Spending The Cash'),
(NULL, 'the_boss', 'The Boss'),
(NULL, 'we_are_rich', 'We are Rich'),
(NULL, 'recruiting_master', 'Join now!');
im_so_popular.png (achieved after getting 10 friends).
graduated.png (achieved after finishing the ManagerPruefung).
Add a prevent listing inside
images/achievements/
Thats all, enjoy it.
Edit: you will have to change where it says "BLA BLA BLA" with an achievements explanation.