Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Achievements v1.1 #125

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Achievements v1.1 #125

wants to merge 6 commits into from

Conversation

cosme12
Copy link
Contributor

@cosme12 cosme12 commented Jul 14, 2014

Ok, here is it. Hope you like it.

Right now, only 2 achievements can be finished (I wanted to avoid to many files changes so you can give me your feedback). Everything is tested and working. There shouldnt be any problem or exploits.

INSERT INTO man_licenseTasks (id, shortName, task) VALUES
(NULL, 'graduated', 'Graduated'),
(NULL, 'happy_birthday', 'Happy Birthday'),
(NULL, 'im_so_popular', 'Im so popular'),
(NULL, 'climbing_the_ladder', 'Climbing the ladder'),
(NULL, 'perfect_score', 'Perfect Score'),
(NULL, 'poeple_adore_me', 'People adore me'),
(NULL, 'double_haat_trick', 'Double Hat-Trick'),
(NULL, 'new_home', 'New Home'),
(NULL, 'the_wall', 'The Wall'),
(NULL, 'invencible', 'Invencible'),
(NULL, 'spending_the_cash', 'Spending The Cash'),
(NULL, 'the_boss', 'The Boss'),
(NULL, 'we_are_rich', 'We are Rich'),
(NULL, 'recruiting_master', 'Join now!');

im_so_popular im_so_popular.png (achieved after getting 10 friends).
graduated graduated.png (achieved after finishing the ManagerPruefung).

Add a prevent listing inside images/achievements/
Thats all, enjoy it.

Edit: you will have to change where it says "BLA BLA BLA" with an achievements explanation.

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 17, 2014

In case you want to know if it is working, here you have the latest version of BM running on my free test server. http://www.ballmanager.tk/

USER PASS
admin demo
demo demo
cosme demo

Here you can see "Achievements v1.1" working online. Just open your profile and check it.

@ocram
Copy link
Contributor

ocram commented Jul 17, 2014

Looks very good, thank you :)

Your test server is great, so we can easily switch between .de and .tk for debugging.

I'll merge this in the next few days. Do I have to merge the old pull request (#117) as well (before) or is this new one a replacement?

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 17, 2014

Nop, this is a brand new complete system. So, there is no need to add the old one. Yeah, in that server is where I break stuff :D Feel free to test anything you like but be carefull with in SQL injection because the server auto bans you (already happened to me haha, so I had to ask the provider to fix it).
Also, http://localize.im/ is full of failed javascript injections attemps (you can see them all just by changing the number after /projects/36, from like 60-99)

@ocram ocram mentioned this pull request Jul 21, 2014
@ocram ocram mentioned this pull request Jul 22, 2014
@ocram
Copy link
Contributor

ocram commented Jul 22, 2014

Go to your database man_teams and check the highest "konto" over there ( that will help me to make a money award, with 3 levels, depending on the money you have).

Another one could be a cake with the number depending on the number of years you have been playing (old players would love it)

These ideas are great! :)

  • Right now you have these, right?
    • When user has 10+ friends, show achievement im_so_popular
    • When user has been signed up for 1+ years, show achievement happy_birthday
  • The other keys (short names) from the database table have not been used yet, right?
  • Are you still using this laurel image which seems fine? :)
  • Is the old system still marking the manager introduction as completed after the user did all old tasks without doing the new tasks?

Localize is full of XSS attempts because some penetration testing has been done by hackers to make sure everything is secure :) Thanks for being attentive! You can check it here: http://security.localize.im/

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 22, 2014

I removed the number with the levels in awards because they look ugly. So i was planing on having 1 level per medal (also changing just 1 numbers is really repetitive). Yes, im still using that laurel. Old system isnt affected by achievements because we start working from id=31. We should change the im_so_popular to 15 or 20, 10 friends seems to be so easy :p
I will give you my entire list of task soon.
Note: dont look at the test server for achievements because i just bugged it with the new updates :P

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 22, 2014

  1. happy_birthday Happy Birthday (year playing)
  2. im_so_popular Im so popular (15 friends)
  3. climbing_the_ladder Climbing the ladder (have 2000 or more RKP)
  4. Perfect score (66 points in league)
  5. people_like_me People like me (100 likes in support)
  6. double_hat_trick Double Hat-Trick (6 or more goals in 1 match)
  7. new_home New Home (stadium size bigger than 50k)
  8. the_wall The Wall (you recived no goals in a league season)
  9. invencible Invencible (your team played the entire season without losing a league game)
  10. spending_the_cash Spending The Cash (You bought a player for £70 million or more)
  11. the_boss The Boss (You won the Manager Of The Year award)
  12. graduated Graduated (completed the tutorial)
  13. we_are_rich We are Rich (own 1000m)
  14. recruiting_master Recruiting Master (recruit 10 players)
  15. the_spy The Spy (watch 15 players)
  16. businessman Businessman (sell one player for £50 million or more)
  17. the_safe_box The Safe Box (set a password with 10 or more characters)
  18. jackpot Jackpot! (win the jackpot)
  19. android_user Android user
  20. merry_xmas Merry X-mas (log in 25th of december)
  21. world_cup_winner World Cup Winner
  22. to_the_top To the Top (have the highest RKP)

@cosme12
Copy link
Contributor Author

cosme12 commented Jul 23, 2014

Fixed manager.php due to the recent updates. Its live in test server.

@cosme12 cosme12 mentioned this pull request Jul 25, 2014
@cosme12
Copy link
Contributor Author

cosme12 commented Apr 30, 2015

I will rework this soon. Due to all the recent changes, this patch doesnt work anymore. Anyways you never liked the icons :P I will try to find a better way of adding this and send you a preview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants