Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI job #2681

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix CI job #2681

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56be530
Skip sharded setup due to errors when running queries
alcaeus Sep 30, 2024
b3d8fcc
Skip upload of composer.lock
alcaeus Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,13 @@ jobs:
dependencies: "highest"
symfony-version: "stable"
# Test with a 5.0 sharded cluster
- topology: "sharded_cluster"
php-version: "8.2"
mongodb-version: "5.0"
driver-version: "stable"
dependencies: "highest"
symfony-version: "stable"
# Currently disabled due to a bug where MongoDB reports "sharding status unknown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is tracked somewhere?
Do we have tests that only run on shared cluster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found SERVER-65939 when looking around, but haven't confirmed that it's the same issue. There's also a large number of BUILDFAILURE tickets that come up in search.

# - topology: "sharded_cluster"
# php-version: "8.2"
# mongodb-version: "5.0"
# driver-version: "stable"
# dependencies: "highest"
# symfony-version: "stable"

steps:
- name: "Checkout"
Expand Down Expand Up @@ -117,13 +118,6 @@ jobs:
dependency-versions: "${{ matrix.dependencies }}"
composer-options: "--prefer-dist"

- name: "Upload composer.lock as build artifact"
uses: actions/upload-artifact@v4
with:
name: "composer-lock-phpunit-${{ matrix.php-version }}-${{ matrix.dependencies }}-${{ matrix.mongodb-version }}"
path: composer.lock
overwrite: true
Comment on lines -120 to -125
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove upload of composer.lock - this fails on 2.10.x due to naming conflicts and its value is questionable at best.

What is the name in conflict with?

I'm fine with removing this artefact since we can find the installed versions in the job logs if necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we only differentiate between files with php version, dependencies, and mongodb version, there may be multiple jobs running producing the same name (e.g. if the jobs only differ in the orchestration file being used.


- id: setup-mongodb
uses: mongodb-labs/drivers-evergreen-tools@master
with:
Expand Down