-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI job #2681
Fix CI job #2681
Conversation
alcaeus
commented
Sep 30, 2024
- Disable tests on sharded cluster due to errors like this one:
- Remove upload of composer.lock - this fails on 2.10.x due to naming conflicts and its value is questionable at best.
driver-version: "stable" | ||
dependencies: "highest" | ||
symfony-version: "stable" | ||
# Currently disabled due to a bug where MongoDB reports "sharding status unknown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug is tracked somewhere?
Do we have tests that only run on shared cluster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found SERVER-65939 when looking around, but haven't confirmed that it's the same issue. There's also a large number of BUILDFAILURE tickets that come up in search.
- name: "Upload composer.lock as build artifact" | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: "composer-lock-phpunit-${{ matrix.php-version }}-${{ matrix.dependencies }}-${{ matrix.mongodb-version }}" | ||
path: composer.lock | ||
overwrite: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove upload of composer.lock - this fails on 2.10.x due to naming conflicts and its value is questionable at best.
What is the name in conflict with?
I'm fine with removing this artefact since we can find the installed versions in the job logs if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we only differentiate between files with php version, dependencies, and mongodb version, there may be multiple jobs running producing the same name (e.g. if the jobs only differ in the orchestration file being used.
* Skip sharded setup due to errors when running queries * Skip upload of composer.lock