Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI job #2681

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Fix CI job #2681

merged 2 commits into from
Oct 1, 2024

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Sep 30, 2024

  • Disable tests on sharded cluster due to errors like this one:

    Transaction 8e609811-9b72-4d9f-a0a2-428b82dc8842:653 was aborted on statement 2 due to: an error from cluster data placement change :: caused by :: Encountered error from localhost:27217 during a transaction :: caused by :: sharding status of collection doctrine_odm_tests.Group is not currently known and needs to be recovered

  • Remove upload of composer.lock - this fails on 2.10.x due to naming conflicts and its value is questionable at best.

@alcaeus alcaeus changed the base branch from 2.10.x to 2.9.x September 30, 2024 13:07
@alcaeus alcaeus requested a review from GromNaN September 30, 2024 13:08
driver-version: "stable"
dependencies: "highest"
symfony-version: "stable"
# Currently disabled due to a bug where MongoDB reports "sharding status unknown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bug is tracked somewhere?
Do we have tests that only run on shared cluster?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found SERVER-65939 when looking around, but haven't confirmed that it's the same issue. There's also a large number of BUILDFAILURE tickets that come up in search.

Comment on lines -120 to -125
- name: "Upload composer.lock as build artifact"
uses: actions/upload-artifact@v4
with:
name: "composer-lock-phpunit-${{ matrix.php-version }}-${{ matrix.dependencies }}-${{ matrix.mongodb-version }}"
path: composer.lock
overwrite: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove upload of composer.lock - this fails on 2.10.x due to naming conflicts and its value is questionable at best.

What is the name in conflict with?

I'm fine with removing this artefact since we can find the installed versions in the job logs if necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we only differentiate between files with php version, dependencies, and mongodb version, there may be multiple jobs running producing the same name (e.g. if the jobs only differ in the orchestration file being used.

@alcaeus alcaeus requested a review from GromNaN September 30, 2024 13:23
@alcaeus alcaeus merged commit 6af8698 into doctrine:2.9.x Oct 1, 2024
16 checks passed
@alcaeus alcaeus deleted the fix-ci branch October 1, 2024 08:07
GromNaN pushed a commit to GromNaN/mongodb-odm that referenced this pull request Oct 19, 2024
* Skip sharded setup due to errors when running queries

* Skip upload of composer.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants