chore(FTM): Add Unlock button to new Toolbar #31096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
changed the title
zJaaal
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
rjvelazco,
valentinogiardino and
KevinDavilaDotCMS
nicobytes
reviewed
Jan 13, 2025
nicobytes
approved these changes
Jan 13, 2025
nicobytes
approved these changes
Jan 13, 2025
valentinogiardino
approved these changes
Jan 13, 2025
oidacra
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new unlock button feature to the
DotUveToolbarComponentand includes various related changes across multiple files. The most important changes include the addition of the unlock button in the HTML template, corresponding styles, service injections, and comprehensive unit tests to ensure the functionality works as expected.Unlock Button Feature:
dot-uve-toolbar.component.html: Added the unlock button with various properties and event binding for unlocking a page.dot-uve-toolbar.component.scss: Added styles for the unlock button, including handling the disabled state.dot-uve-toolbar.component.ts: InjectedDotContentletLockerServiceand added theunlockPagemethod to handle the unlocking logic. [1] [2] [3]dot-uve-toolbar.component.spec.ts: Added unit tests for the unlock button, including tests for visibility, state, and service call verification. [1] [2] [3] [4] [5] [6]Additional Changes:
models.ts: Updated interfaces to includeUnlockOptionsfor the new unlock button feature.withUVEToolbar.spec.ts: Adjusted the initial state to includemockCurrentUserfor testing purposes. [1] [2]This PR fixes: #31082