Skip to content

Commit

Permalink
Bug 1351910 - Build more files as unified in ipc/glue. r=billm
Browse files Browse the repository at this point in the history
One file was excluded for using plarena which it did not. The other was
excluded for "clashes with strdup," it does not use strdup.

MozReview-Commit-ID: 5X5H9S4j903
  • Loading branch information
EricRahm committed Apr 10, 2017
1 parent 3ab41f1 commit b993050
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 4 deletions.
3 changes: 3 additions & 0 deletions ipc/glue/IPCStreamUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@
#include "nsIAsyncInputStream.h"
#include "nsIAsyncOutputStream.h"
#include "nsIPipe.h"
#include "nsNetCID.h"
#include "nsStreamUtils.h"

using namespace mozilla::dom;

namespace mozilla {
namespace ipc {

Expand Down
16 changes: 12 additions & 4 deletions ipc/glue/moz.build
Original file line number Diff line number Diff line change
Expand Up @@ -158,19 +158,27 @@ UNIFIED_SOURCES += [
'SharedMemory.cpp',
'Shmem.cpp',
'StringUtil.cpp',
'URIUtils.cpp',
]

# GeckoChildProcessHost.cpp cannot be built in unified mode because it uses plarena.h.
# URIUtils.cpp cannot be built in unified mode because of name clashes on strdup.
SOURCES += [
'BackgroundChildImpl.cpp',
'BackgroundParentImpl.cpp',
'FileDescriptorSetChild.cpp',
'FileDescriptorSetParent.cpp',
'GeckoChildProcessHost.cpp',
'URIUtils.cpp',
]

if CONFIG['OS_ARCH'] == 'Darwin':
# GeckoChildProcessHost.cpp cannot be built unified due to OSX header
# clashes with TextRange.
SOURCES += [
'GeckoChildProcessHost.cpp',
]
else:
UNIFIED_SOURCES += [
'GeckoChildProcessHost.cpp',
]

if CONFIG['_MSC_VER']:
# This is intended as a temporary hack to support building with VS2015.
# 'reinterpret_cast': conversion from 'DWORD' to 'HANDLE' of greater size
Expand Down

0 comments on commit b993050

Please sign in to comment.