-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 3007 vx ioda #3050
Open
hsoh-u
wants to merge
59
commits into
develop
Choose a base branch
from
feature_3007_vx_ioda
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature 3007 vx ioda #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ol with all instances of point_stat renamed as pair_stat.
…t' command is run.
… change was not meaningful or warranted.
… change was not meaningful or warranted.
…DataConfig_default file to store default settings for reading IODA data.
…'s successfully compiling
… be used in the pair_stat tool.
…ype_Pairs enumerated value.
development branch. Merge remote-tracking branch 'origin/feature_3007_vx_ioda' into feature_3006_pair_stat
…f the vx_ioda library.
…of them to avoid compilation conflict.
…tat_out/stat_hdr_info.h/.cc. This make it available to both Stat-Analysis and the Pair-Stat tool to track the unique STAT headers elements read.
…rom the pair_stat tool's configuration file and code that parses it. If needed, we can add it back in the future.
…l library now also depends on the
…ture_3007_vx_ioda
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Added
vx_ioda
library andioda2nc
was refactored with the vx_ioda libraryThe feature branch
feature_3006_pair_stat
was merged. Some SonarQube findings fromfeature_3006_pair_stat
branch were not resolved.Changed the internal variable data type for ioda variable to double.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
THe same unittest outputs except two outputs with
ioda2nc
But no suggestion for the extra testing
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
The valid time from the data type int64 was corrected. The float data type did not fit to handle big integers.
If yes, create a new Update Truth METplus issue to describe them.
Yes if the the data variable is the unixtime (int64 data type and "seconds since 1970-01-01T00:00:00Z"):
If yes, please describe:
Reduced for vx_ioda and iodas2nc, but introduced from pair_stat component (from another feature branch
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases