Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3007 vx ioda #3050

Open
wants to merge 59 commits into
base: develop
Choose a base branch
from
Open

Feature 3007 vx ioda #3050

wants to merge 59 commits into from

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Jan 14, 2025

Expected Differences

Added vx_ioda library and ioda2nc was refactored with the vx_ioda library
The feature branch feature_3006_pair_stat was merged. Some SonarQube findings from feature_3006_pair_stat branch were not resolved.

Changed the internal variable data type for ioda variable to double.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

THe same unittest outputs except two outputs with ioda2nc

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

But no suggestion for the extra testing

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the MET test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

The valid time from the data type int64 was corrected. The float data type did not fit to handle big integers.

  • iodas2nc/2021081612_sonde_small_sid.nc
  • the number of valid times was increased from 43 to 291.
  • headers were increased from 165 to 304
  • iodas2nc/jopa_satwind_20210701T1200Z_int_datetime.nc: corrected the valid times
    • before
      • "20210701_091024"
      • "20210701_085944"
      • "20210701_092936"
      • ...
    • after
      • "20210701_091000"
      • "20210701_090000"
      • "20210701_093000"
    • input data:
      • dateTime = 1625130600, 1625130600, 1625130600, 1625130000, 1625131800,
hsoh@seneca:~$ date +"%Y%m%d_%H%M%S" -d @1625130600
20210701_091000
hsoh@seneca:~$ date +"%Y%m%d_%H%M%S" -d @1625130000
20210701_090000
hsoh@seneca:~$ date +"%Y%m%d_%H%M%S" -d @1625131800
20210701_093000
  • Will this PR result in changes to existing METplus Use Cases? [Yes or No]

    If yes, create a new Update Truth METplus issue to describe them.

Yes if the the data variable is the unixtime (int64 data type and "seconds since 1970-01-01T00:00:00Z"):

        int64 dateTime(nlocs) ;
                dateTime:_FillValue = -9223372036854775801LL ;
                string dateTime:units = "seconds since 1970-01-01T00:00:00Z" ;
  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe:

Reduced for vx_ioda and iodas2nc, but introduced from pair_stat component (from another feature branch

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway and others added 30 commits November 5, 2024 23:42
…ol with all instances of point_stat renamed as pair_stat.
…DataConfig_default file to store default settings for reading IODA data.
Howard Soh and others added 27 commits December 23, 2024 11:41
development branch.

Merge remote-tracking branch 'origin/feature_3007_vx_ioda' into feature_3006_pair_stat
…tat_out/stat_hdr_info.h/.cc. This make it available to both Stat-Analysis and the Pair-Stat tool to track the unique STAT headers elements read.
…rom the pair_stat tool's configuration file and code that parses it. If needed, we can add it back in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Develop a class that supports reading both FCST and OBS from a IODA file to use with the new Pair-Stat tool
2 participants