Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3007 vx ioda #3050

Closed
wants to merge 59 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
b4741e7
Per #3006, add new pair_stat tool as a full copy of the point_stat to…
JohnHalleyGotway Nov 5, 2024
3ff4d7f
Per #3006, add pair_stat to the list of things for which no 'make tes…
JohnHalleyGotway Nov 7, 2024
da85f7a
Merge remote-tracking branch 'origin/develop' into feature_3006_pair_…
JohnHalleyGotway Nov 18, 2024
f99af01
Per #3006, saving work in progress prior to seneca reboot
JohnHalleyGotway Nov 18, 2024
6afe990
Per #3006, revert back to using FileType instead of GrdFileType. That…
JohnHalleyGotway Nov 19, 2024
5e431c4
Per #3006, revert back to using FileType instead of GrdFileType. That…
JohnHalleyGotway Nov 19, 2024
ac43a80
Merge remote-tracking branch 'origin/develop' into feature_3006_pair_…
JohnHalleyGotway Dec 3, 2024
9ae08da
Per #3006, committing changes since the code is compiling. Added IODA…
JohnHalleyGotway Dec 3, 2024
982cf62
Per #3006, starting to tweak config options. Saving progress while it…
JohnHalleyGotway Dec 4, 2024
b661a2b
Merge remote-tracking branch 'origin/develop' into feature_3006_pair_…
JohnHalleyGotway Dec 16, 2024
c8b8c41
Per #3006, add fcst.pairs and obs.pairs config entries.
JohnHalleyGotway Dec 16, 2024
752420c
#3007 Added vx_ioda
Dec 17, 2024
00a3949
#3007 Added vx_ioda
Dec 17, 2024
2e4fbcd
#3007 Added vx_ioda
Dec 17, 2024
922b3ce
#3007 Derived from IODADataConfInfo
Dec 17, 2024
bcf1709
#3007 Reduced the code smells (SonarQube findings)
Dec 20, 2024
4186e9c
#3007 Added station_value_base_t and point_pair_t
Dec 20, 2024
1b50145
Initial release
Dec 20, 2024
5eb7018
#3007 Changed ack the location of nc_point_obs.set_nc_out_data
Dec 20, 2024
d78084b
Merge remote-tracking branch 'origin/develop' into feature_3007_vx_ioda
Dec 20, 2024
e812745
Changed station_value_base_t::clear() to station_value_base_t::clear_…
Dec 21, 2024
25f753d
Changed bAPI names
Dec 21, 2024
f14e0bc
#3007 Reduced code smells
Dec 21, 2024
bc438d8
#3007 CLeanup
Dec 21, 2024
587dd70
#3007 Cahnged API for IODADataConfInfo
Dec 21, 2024
d8467bf
#3007 Renamed ioda_file to ioda_reader
Dec 21, 2024
031c256
#3007 Corrected comment
Dec 23, 2024
e59b43c
#3007 Added -lvx_statistics again
Dec 23, 2024
9f24f77
#3007 Added get_nc_data(NcVar *, unixtime)
Dec 23, 2024
c7b992e
#3007 Cleanup
Dec 23, 2024
f7db1de
#3007 Added add_to_unixtime((unixtime)
Dec 23, 2024
7483c36
#3007 Reduced the complexiity of read_time. Added read_time_as_number
Dec 23, 2024
109d1ac
#3007 Added read_time_as_number
Dec 23, 2024
82b6229
#3007 Added add_to_unixtime(unixtime)
Dec 23, 2024
7f670a1
#3007 Cleanup
Dec 23, 2024
5880bf1
#3007 Set bad_data_int to qc_buf
Dec 23, 2024
66e4deb
#3007 Cleanup
Dec 23, 2024
21bd9ef
#3007 Resolve conflicts with feature_3006_pair_stat
Dec 23, 2024
b271ed0
Merge remote-tracking branch 'origin/develop' into feature_3006_pair_…
JohnHalleyGotway Dec 26, 2024
4a9c387
Per #3006, define new GrdFileType::FileType_Pairs enumerated value to…
JohnHalleyGotway Dec 26, 2024
5325ee9
Per #3006, update pair_stat to use the newly added GrdFileType::FileT…
JohnHalleyGotway Dec 26, 2024
62768dc
Merging Howard's ioda development branch into the pair_stat tool
JohnHalleyGotway Dec 26, 2024
3f6f1ed
#3007 Temporarily removed pair_stat
Dec 26, 2024
7e2cad1
Per #3006, rerun bootstrap on seneca to incorporate the compilation o…
JohnHalleyGotway Dec 26, 2024
0b93009
Per #3006, make docs build without warning
JohnHalleyGotway Dec 26, 2024
eda1b90
Per #3006, saving compiling state
JohnHalleyGotway Dec 27, 2024
c6dbfb6
Per #3006, use ConcatString instead of std::string for consistency.
JohnHalleyGotway Dec 27, 2024
d926506
Per #3006, work in progress
JohnHalleyGotway Dec 27, 2024
909401e
Unrelated to #3006, but fix typo in log message.
JohnHalleyGotway Dec 30, 2024
f3b577a
Per #3006, default_column_union was defined in 2 spots. Renaming one …
JohnHalleyGotway Dec 31, 2024
42fb21e
Per #3006, move StatHdrInfo out of aggr_stat_line.h/.cc and into vx_s…
JohnHalleyGotway Dec 31, 2024
7a5415a
Per #3006, remove the unused land/topo/msg_type type config options f…
JohnHalleyGotway Dec 31, 2024
fc7f0c8
Per #3006, update VarInfoPairs::set_dict() to also call VarInfo::set_…
JohnHalleyGotway Dec 31, 2024
b066f5b
Per #3006, since python_line.h lives in src/basic/vx_util, the vx_uti…
JohnHalleyGotway Dec 31, 2024
54bc949
Per #3006, saving off version that compiles before trying changes tha…
JohnHalleyGotway Dec 31, 2024
081cb70
#3007 Deleted commented out cpde
Jan 8, 2025
d809a92
Changed data typo (float to double)
Jan 8, 2025
5a45937
#3007 Resio;lved SonarQube finding
Jan 14, 2025
2142068
Merge remote-tracking branch 'origin/feature_3006_pair_stat' into fea…
Jan 14, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Per #3006, add new pair_stat tool as a full copy of the point_stat to…
…ol with all instances of point_stat renamed as pair_stat.
  • Loading branch information
JohnHalleyGotway committed Nov 5, 2024
commit b4741e78d13f94e17bec454d5147dbdfed0ccadc
2 changes: 1 addition & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ jobs:
matrix:
include:
- jobid: 'job1'
tests: 'point_stat stat_analysis_ps'
tests: 'point_stat pair_stat stat_analysis_ps'
- jobid: 'job2'
tests: 'grid_stat stat_analysis_gs'
- jobid: 'job3'
Expand Down
3 changes: 3 additions & 0 deletions config.h.in
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
/* "build modis" */
#undef ENABLE_MODIS

/* "build pair_stat" */
#undef ENABLE_PAIR_STAT

/* "build pb2nc" */
#undef ENABLE_PB2NC

Expand Down
46 changes: 45 additions & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,8 @@ ENABLE_WAVELET_STAT_FALSE
ENABLE_WAVELET_STAT_TRUE
ENABLE_STAT_ANALYSIS_FALSE
ENABLE_STAT_ANALYSIS_TRUE
ENABLE_PAIR_STAT_FALSE
ENABLE_PAIR_STAT_TRUE
ENABLE_POINT_STAT_FALSE
ENABLE_POINT_STAT_TRUE
ENABLE_PLOT_POINT_OBS_FALSE
Expand Down Expand Up @@ -913,6 +915,7 @@ enable_point2grid
enable_shift_data_plane
enable_plot_point_obs
enable_point_stat
enable_pair_stat
enable_stat_analysis
enable_wavelet_stat
enable_series_analysis
Expand Down Expand Up @@ -1645,6 +1648,7 @@ Optional Features:
--disable-plot_point_obs
Disable compilation of plot_point_obs
--disable-point_stat Disable compilation of point_stat
--disable-pair_stat Disable compilation of pair_stat
--disable-stat_analysis Disable compilation of stat_analysis
--disable-wavelet_stat Disable compilation of wavelet_stat
--disable-series_analysis
Expand Down Expand Up @@ -6538,6 +6542,41 @@ else
printf "%s\n" "$as_me: point_stat will not be compiled" >&6;}
fi

# pair_stat

# Check whether --enable-pair_stat was given.
if test ${enable_pair_stat+y}
then :
enableval=$enable_pair_stat; case "${enableval}" in
yes | no ) ENABLE_PAIR_STAT="${enableval}" ;;
*) as_fn_error $? "bad value ${enableval} for --disable-pair_stat" "$LINENO" 5 ;;
esac
else $as_nop
ENABLE_PAIR_STAT="yes"

fi


if test "x$ENABLE_PAIR_STAT" = "xyes"; then
ENABLE_PAIR_STAT_TRUE=
ENABLE_PAIR_STAT_FALSE='#'
else
ENABLE_PAIR_STAT_TRUE='#'
ENABLE_PAIR_STAT_FALSE=
fi


if test "x$ENABLE_PAIR_STAT" = "xyes"; then

printf "%s\n" "#define ENABLE_PAIR_STAT /**/" >>confdefs.h

{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: pair_stat will be compiled" >&5
printf "%s\n" "$as_me: pair_stat will be compiled" >&6;}
else
{ printf "%s\n" "$as_me:${as_lineno-$LINENO}: pair_stat will not be compiled" >&5
printf "%s\n" "$as_me: pair_stat will not be compiled" >&6;}
fi

# stat_analysis

# Check whether --enable-stat_analysis was given.
Expand Down Expand Up @@ -10158,7 +10197,7 @@ fi

# Create configured files

ac_config_files="$ac_config_files Makefile scripts/Rscripts/Makefile scripts/Rscripts/include/Makefile scripts/python/Makefile scripts/python/examples/Makefile scripts/python/met/Makefile scripts/python/pyembed/Makefile scripts/python/utility/Makefile scripts/python/tc_diag/Makefile scripts/python/tc_diag/atcf_tools/Makefile scripts/python/tc_diag/config/Makefile scripts/python/tc_diag/diag_lib/Makefile scripts/python/tc_diag/tc_diag_driver/Makefile data/Makefile data/climo/Makefile data/climo/seeps/Makefile data/colortables/Makefile data/colortables/NCL_colortables/Makefile data/config/Makefile data/map/Makefile data/map/admin_by_country/Makefile data/poly/Makefile data/poly/HMT_masks/Makefile data/poly/NCEP_masks/Makefile data/ps/Makefile data/table_files/Makefile data/tc_data/Makefile src/Makefile src/basic/Makefile src/basic/enum_to_string/Makefile src/basic/vx_cal/Makefile src/basic/vx_config/Makefile src/basic/vx_log/Makefile src/basic/vx_math/Makefile src/basic/vx_util/Makefile src/basic/vx_util_math/Makefile src/libcode/Makefile src/libcode/vx_afm/Makefile src/libcode/vx_analysis_util/Makefile src/libcode/vx_color/Makefile src/libcode/vx_data2d/Makefile src/libcode/vx_data2d_factory/Makefile src/libcode/vx_data2d_grib/Makefile src/libcode/vx_data2d_grib2/Makefile src/libcode/vx_data2d_nc_met/Makefile src/libcode/vx_data2d_nc_wrf/Makefile src/libcode/vx_data2d_nc_cf/Makefile src/libcode/vx_data2d_ugrid/Makefile src/libcode/vx_geodesy/Makefile src/libcode/vx_gis/Makefile src/libcode/vx_gnomon/Makefile src/libcode/vx_grid/Makefile src/libcode/vx_gsl_prob/Makefile src/libcode/vx_nav/Makefile src/libcode/vx_solar/Makefile src/libcode/vx_nc_obs/Makefile src/libcode/vx_nc_util/Makefile src/libcode/vx_pb_util/Makefile src/libcode/vx_plot_util/Makefile src/libcode/vx_ps/Makefile src/libcode/vx_pxm/Makefile src/libcode/vx_render/Makefile src/libcode/vx_shapedata/Makefile src/libcode/vx_stat_out/Makefile src/libcode/vx_statistics/Makefile src/libcode/vx_time_series/Makefile src/libcode/vx_physics/Makefile src/libcode/vx_series_data/Makefile src/libcode/vx_regrid/Makefile src/libcode/vx_tc_util/Makefile src/libcode/vx_summary/Makefile src/libcode/vx_python3_utils/Makefile src/libcode/vx_data2d_python/Makefile src/libcode/vx_bool_calc/Makefile src/libcode/vx_pointdata_python/Makefile src/libcode/vx_seeps/Makefile src/tools/Makefile src/tools/core/Makefile src/tools/core/ensemble_stat/Makefile src/tools/core/grid_stat/Makefile src/tools/core/mode/Makefile src/tools/core/mode_analysis/Makefile src/tools/core/pcp_combine/Makefile src/tools/core/point_stat/Makefile src/tools/core/series_analysis/Makefile src/tools/core/stat_analysis/Makefile src/tools/core/wavelet_stat/Makefile src/tools/other/Makefile src/tools/other/ascii2nc/Makefile src/tools/other/lidar2nc/Makefile src/tools/other/gen_ens_prod/Makefile src/tools/other/gen_vx_mask/Makefile src/tools/other/gis_utils/Makefile src/tools/other/ioda2nc/Makefile src/tools/other/madis2nc/Makefile src/tools/other/mode_graphics/Makefile src/tools/other/modis_regrid/Makefile src/tools/other/pb2nc/Makefile src/tools/other/plot_data_plane/Makefile src/tools/other/plot_point_obs/Makefile src/tools/other/wwmca_tool/Makefile src/tools/other/gsi_tools/Makefile src/tools/other/regrid_data_plane/Makefile src/tools/other/point2grid/Makefile src/tools/other/shift_data_plane/Makefile src/tools/other/mode_time_domain/Makefile src/tools/other/grid_diag/Makefile src/tools/tc_utils/Makefile src/tools/tc_utils/tc_dland/Makefile src/tools/tc_utils/tc_pairs/Makefile src/tools/tc_utils/tc_stat/Makefile src/tools/tc_utils/tc_gen/Makefile src/tools/tc_utils/rmw_analysis/Makefile src/tools/tc_utils/tc_rmw/Makefile src/tools/tc_utils/tc_diag/Makefile"
ac_config_files="$ac_config_files Makefile scripts/Rscripts/Makefile scripts/Rscripts/include/Makefile scripts/python/Makefile scripts/python/examples/Makefile scripts/python/met/Makefile scripts/python/pyembed/Makefile scripts/python/utility/Makefile scripts/python/tc_diag/Makefile scripts/python/tc_diag/atcf_tools/Makefile scripts/python/tc_diag/config/Makefile scripts/python/tc_diag/diag_lib/Makefile scripts/python/tc_diag/tc_diag_driver/Makefile data/Makefile data/climo/Makefile data/climo/seeps/Makefile data/colortables/Makefile data/colortables/NCL_colortables/Makefile data/config/Makefile data/map/Makefile data/map/admin_by_country/Makefile data/poly/Makefile data/poly/HMT_masks/Makefile data/poly/NCEP_masks/Makefile data/ps/Makefile data/table_files/Makefile data/tc_data/Makefile src/Makefile src/basic/Makefile src/basic/enum_to_string/Makefile src/basic/vx_cal/Makefile src/basic/vx_config/Makefile src/basic/vx_log/Makefile src/basic/vx_math/Makefile src/basic/vx_util/Makefile src/basic/vx_util_math/Makefile src/libcode/Makefile src/libcode/vx_afm/Makefile src/libcode/vx_analysis_util/Makefile src/libcode/vx_color/Makefile src/libcode/vx_data2d/Makefile src/libcode/vx_data2d_factory/Makefile src/libcode/vx_data2d_grib/Makefile src/libcode/vx_data2d_grib2/Makefile src/libcode/vx_data2d_nc_met/Makefile src/libcode/vx_data2d_nc_wrf/Makefile src/libcode/vx_data2d_nc_cf/Makefile src/libcode/vx_data2d_ugrid/Makefile src/libcode/vx_geodesy/Makefile src/libcode/vx_gis/Makefile src/libcode/vx_gnomon/Makefile src/libcode/vx_grid/Makefile src/libcode/vx_gsl_prob/Makefile src/libcode/vx_nav/Makefile src/libcode/vx_solar/Makefile src/libcode/vx_nc_obs/Makefile src/libcode/vx_nc_util/Makefile src/libcode/vx_pb_util/Makefile src/libcode/vx_plot_util/Makefile src/libcode/vx_ps/Makefile src/libcode/vx_pxm/Makefile src/libcode/vx_render/Makefile src/libcode/vx_shapedata/Makefile src/libcode/vx_stat_out/Makefile src/libcode/vx_statistics/Makefile src/libcode/vx_time_series/Makefile src/libcode/vx_physics/Makefile src/libcode/vx_series_data/Makefile src/libcode/vx_regrid/Makefile src/libcode/vx_tc_util/Makefile src/libcode/vx_summary/Makefile src/libcode/vx_python3_utils/Makefile src/libcode/vx_data2d_python/Makefile src/libcode/vx_bool_calc/Makefile src/libcode/vx_pointdata_python/Makefile src/libcode/vx_seeps/Makefile src/tools/Makefile src/tools/core/Makefile src/tools/core/ensemble_stat/Makefile src/tools/core/grid_stat/Makefile src/tools/core/mode/Makefile src/tools/core/mode_analysis/Makefile src/tools/core/pcp_combine/Makefile src/tools/core/point_stat/Makefile src/tools/core/pair_stat/Makefile src/tools/core/series_analysis/Makefile src/tools/core/stat_analysis/Makefile src/tools/core/wavelet_stat/Makefile src/tools/other/Makefile src/tools/other/ascii2nc/Makefile src/tools/other/lidar2nc/Makefile src/tools/other/gen_ens_prod/Makefile src/tools/other/gen_vx_mask/Makefile src/tools/other/gis_utils/Makefile src/tools/other/ioda2nc/Makefile src/tools/other/madis2nc/Makefile src/tools/other/mode_graphics/Makefile src/tools/other/modis_regrid/Makefile src/tools/other/pb2nc/Makefile src/tools/other/plot_data_plane/Makefile src/tools/other/plot_point_obs/Makefile src/tools/other/wwmca_tool/Makefile src/tools/other/gsi_tools/Makefile src/tools/other/regrid_data_plane/Makefile src/tools/other/point2grid/Makefile src/tools/other/shift_data_plane/Makefile src/tools/other/mode_time_domain/Makefile src/tools/other/grid_diag/Makefile src/tools/tc_utils/Makefile src/tools/tc_utils/tc_dland/Makefile src/tools/tc_utils/tc_pairs/Makefile src/tools/tc_utils/tc_stat/Makefile src/tools/tc_utils/tc_gen/Makefile src/tools/tc_utils/rmw_analysis/Makefile src/tools/tc_utils/tc_rmw/Makefile src/tools/tc_utils/tc_diag/Makefile"


if test -n "$MET_DEVELOPMENT"; then
Expand Down Expand Up @@ -10391,6 +10430,10 @@ if test -z "${ENABLE_POINT_STAT_TRUE}" && test -z "${ENABLE_POINT_STAT_FALSE}";
as_fn_error $? "conditional \"ENABLE_POINT_STAT\" was never defined.
Usually this means the macro was only invoked conditionally." "$LINENO" 5
fi
if test -z "${ENABLE_PAIR_STAT_TRUE}" && test -z "${ENABLE_PAIR_STAT_FALSE}"; then
as_fn_error $? "conditional \"ENABLE_PAIR_STAT\" was never defined.
Usually this means the macro was only invoked conditionally." "$LINENO" 5
fi
if test -z "${ENABLE_STAT_ANALYSIS_TRUE}" && test -z "${ENABLE_STAT_ANALYSIS_FALSE}"; then
as_fn_error $? "conditional \"ENABLE_STAT_ANALYSIS\" was never defined.
Usually this means the macro was only invoked conditionally." "$LINENO" 5
Expand Down Expand Up @@ -11129,6 +11172,7 @@ do
"src/tools/core/mode_analysis/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/mode_analysis/Makefile" ;;
"src/tools/core/pcp_combine/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/pcp_combine/Makefile" ;;
"src/tools/core/point_stat/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/point_stat/Makefile" ;;
"src/tools/core/pair_stat/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/pair_stat/Makefile" ;;
"src/tools/core/series_analysis/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/series_analysis/Makefile" ;;
"src/tools/core/stat_analysis/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/stat_analysis/Makefile" ;;
"src/tools/core/wavelet_stat/Makefile") CONFIG_FILES="$CONFIG_FILES src/tools/core/wavelet_stat/Makefile" ;;
Expand Down
21 changes: 21 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,26 @@ else
AC_MSG_NOTICE([point_stat will not be compiled])
fi

# pair_stat

AC_ARG_ENABLE(pair_stat,
[AS_HELP_STRING([--disable-pair_stat], [Disable compilation of pair_stat])],
[case "${enableval}" in
yes | no ) ENABLE_PAIR_STAT="${enableval}" ;;
*) AC_MSG_ERROR(bad value ${enableval} for --disable-pair_stat) ;;
esac],
[ENABLE_PAIR_STAT="yes"]
)

AM_CONDITIONAL([ENABLE_PAIR_STAT], [test "x$ENABLE_PAIR_STAT" = "xyes"])

if test "x$ENABLE_PAIR_STAT" = "xyes"; then
AC_DEFINE([ENABLE_PAIR_STAT], [], ["build pair_stat"])
AC_MSG_NOTICE([pair_stat will be compiled])
else
AC_MSG_NOTICE([pair_stat will not be compiled])
fi

# stat_analysis

AC_ARG_ENABLE(stat_analysis,
Expand Down Expand Up @@ -1378,6 +1398,7 @@ AC_CONFIG_FILES([Makefile
src/tools/core/mode_analysis/Makefile
src/tools/core/pcp_combine/Makefile
src/tools/core/point_stat/Makefile
src/tools/core/pair_stat/Makefile
src/tools/core/series_analysis/Makefile
src/tools/core/stat_analysis/Makefile
src/tools/core/wavelet_stat/Makefile
Expand Down
1 change: 1 addition & 0 deletions data/config/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ config_DATA = \
MTDConfig_default \
PB2NCConfig_default \
PointStatConfig_default \
PairStatConfig_default \
SeriesAnalysisConfig_default \
STATAnalysisConfig_default \
STATAnalysisConfig_GO_Index \
Expand Down
1 change: 1 addition & 0 deletions data/config/Makefile.in
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ config_DATA = \
MTDConfig_default \
PB2NCConfig_default \
PointStatConfig_default \
PairStatConfig_default \
SeriesAnalysisConfig_default \
STATAnalysisConfig_default \
STATAnalysisConfig_GO_Index \
Expand Down
Loading
Loading