Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar, EuiToken #8225

Merged
merged 6 commits into from
Dec 12, 2024
Merged

[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar, EuiToken #8225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b17965
[EuiKeyPadMenu] [setup] CSS cleanup, VRT updates
cee-chen Dec 11, 2024
5e3f58d
[EuiKeyPadMenu] Improve high contrast rendering via `outline` CSS
cee-chen Dec 11, 2024
3050426
[EuiImage] Improve high contrast borders
cee-chen Dec 11, 2024
53cf297
[EuiOverlayMask] Decrease opacity in high contrast mode
cee-chen Dec 11, 2024
984c9c8
[EuiBottomBar] Add border-top to match recent `EuiHeader` change
cee-chen Dec 11, 2024
cac6be2
[EuiToken] Improve high contrast border rendering
cee-chen Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[EuiBottomBar] Add border-top to match recent EuiHeader change 
- which now always has a border-bottom line on dark mode

+ hide shadow on high contrast
  • Loading branch information
@cee-chen
cee-chen committed Dec 12, 2024
commit 984c9c82ed847640cb7a3a1891aa19ab03f250e3
Binary file modified packages/eui/.loki/reference/chrome_desktop_Layout_EuiBottomBar_Playground.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified packages/eui/.loki/reference/chrome_mobile_Layout_EuiBottomBar_Playground.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 8 additions & 3 deletions packages/eui/src/components/bottom_bar/bottom_bar.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
*/

import { css, keyframes } from '@emotion/react';
import { euiCanAnimate } from '../../global_styling';
import { UseEuiTheme, shade } from '../../services';
import { euiCanAnimate, logicalCSS } from '../../global_styling';
import { highContrastModeStyles } from '../../global_styling/functions/high_contrast';
import { euiShadowFlat } from '../../themes/amsterdam/global_styling/mixins';

const euiBottomBarAppear = keyframes`
Expand All @@ -30,8 +31,12 @@ export const euiBottomBarStyles = (euiThemeContext: UseEuiTheme) => {
// Base
// `color` is inherited from the wrapping `EuiThemeProvider colorMode="dark"`
euiBottomBar: css`
${euiShadowFlat(euiThemeContext)}
background: ${shade(euiTheme.colors.lightestShade, 0.5)};
background-color: ${shade(euiTheme.colors.lightestShade, 0.5)};
${logicalCSS('border-top', euiTheme.border.thin)}
${highContrastModeStyles(euiThemeContext, {
none: euiShadowFlat(euiThemeContext),
})}

${euiCanAnimate} {
animation: ${euiBottomBarAppear} ${euiTheme.animation.slow}
${euiTheme.animation.resistance};
Expand Down