Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar, EuiToken #8225

Merged
merged 6 commits into from
Dec 12, 2024
Merged

[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar, EuiToken #8225

merged 6 commits into from
Dec 12, 2024

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Dec 12, 2024 •
edited
Loading

Summary

Note

This PR merges into a feature branch

Kind of the "misc random components" part of my pass over our docs 😅 Should be fairly straightforward in terms of code changes, but as always open to feedback!

QA

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked for accessibility including keyboard-only and screenreader modes
      - [ ] Checked in mobile
      - [ ] Checked in Chrome, Safari, Edge, and Firefox
  • Docs site QA - N/A
  • Code quality checklist
    - [ ] Added or updated jest and cypress tests
  • Release checklist - N/A, feature branch
  • Designer checklist - N/A

@cee-chen cee-chen force-pushed the high-contrast-mode-9 branch from d49aa71 to 984c9c8 Compare December 12, 2024 07:12
@cee-chen cee-chen marked this pull request as ready for review December 12, 2024 07:15
@cee-chen cee-chen requested a review from a team as a code owner December 12, 2024 07:15
@cee-chen cee-chen changed the title [High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar [High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBottomBar, EuiToken Dec 12, 2024
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

mgadewoll
mgadewoll approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ All updates look good to me and they are working well.
I left one suggestion, but feel free to ignore if you don't think that cut-offs are an issue to consider.

packages/eui/src/components/key_pad_menu/key_pad_menu_item.styles.ts Show resolved Hide resolved
@cee-chen cee-chen merged commit aeddb68 into elastic:high-contrast-mode Dec 12, 2024
4 checks passed
@cee-chen cee-chen deleted the high-contrast-mode-9 branch December 12, 2024 17:17
cee-chen added a commit that referenced this pull request Dec 12, 2024
@cee-chen
[High Contrast Mode] EuiKeyPadMenu, EuiImage, EuiOverlayMask, EuiBott…
8e6f8c1 
…omBar, EuiToken (#8225)
@cee-chen cee-chen mentioned this pull request Dec 12, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgadewoll mgadewoll mgadewoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cee-chen @kibanamachine @elasticmachine @mgadewoll