ref(chunks): Make render_detail take Option<&str>
#2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Dec 17, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-11
branch
from
fafb281 to
3a8b380
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-12
branch
from
3c8f73c to
0c48e66
Compare
Base automatically changed from
szokeasaurusrex/proguard-upload-11
to
master
December 18, 2024 13:22
Previously, this function took as its first argument an `&Option<String>`. `Option<&str>` is typically preferred over this. This change also allows us to simplify the logic for computing the detail string. Co-authored-by: Sebastian Zivota <[email protected]>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload-12
branch
from
e6f01fa to
27c7296
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this function took as its first argument an
&Option<String>.Option<&str>is typically preferred over this. This change also allows us to simplify the logic for computing the detail string.