-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing two recognize-gesture deprecation messages #137
base: master
Are you sure you want to change the base?
Conversation
Fixed invocation of -gestures service during render. ember-modifiers use now requires minimum Ember 3.3.
The travis-ci failures in LTS 2.12, 2.16, 2.18 are expected with this change. We're effectively reducing the range of Ember versions with which this will work so that the modifier will work without deprecations in recent versions of Ember. It will definitely need a new major version to insulate users of Ember < 3.3 from the change. |
@lupestro willRemove() {
this.manager.destroy();
this.manager = null;
} to willRemove() {
if (this.manager !== null) {
this.manager.destroy();
this.manager = null;
}
} |
Hi @pieter-v - I swung back around here, doing maintenance on a related project, and stumbled over your comment from back in March. I'll make the fix shortly. Sorry for the long delay. |
@lupestro thanx |
Fixes a deprecation warning when used with Ember 3.24. Taken from html-next/ember-gestures#137
Fixes a deprecation warning when used with Ember 3.24. Taken from html-next/ember-gestures#137
Updated
recognize-gesture
modifier to use latestember-modifier
(fixes one deprecation)Fixed
recognize-gesture
invocation of-gestures
service during render (fixes the other)Using ember-modifier requires a minimum of Ember 3.3 (rather than 3.1) for ember-destroyable-plugin, which it calls internally, to function. Not sure if that qualifies this fix to be a sem-ver major bump, but I suspect so.
I'll defer updating the changelog until I hear what the committers want to do.