Stock API and plot function update #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyword argument `b` is no longer available for function `plt.grid()`, just remove it.
`get_daily_adjusted` is a premium api. Use `get_daily` instead.
|
Thank you, @TianYuanSX, for this PR. It is very helpful for me to run this tutorial without issues. I hope this PR will be reviewed and merged soon. |
ofenloch
added a commit
to ofenloch/time-series-forecasting-pytorch
that referenced
this pull request
Dec 31, 2024
This chage is suggested by [TianYuanSX](https://github.com/TianYuanSX) in his [comment on issue jinglescode#22](jinglescode#22 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jingles,
Thanks for this great tutorial. I'm a student interested in Python finance.
I found some parts of the code require updates. And I tried to fix them.
plt.grid()no longer accepts keywordb=None. I just removed it. otherwise, this function will raise an exception. See matplotlib.pyplot.gridBest regards,
Yuan