Experiment using withFooPage(cb) to scope particular pages. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I think for a developer that spends all day working in production code this change makes sense. One pro is using an established pattern that can be used and understood by developers who are used to working with abstractions all over the place. However, taking the original albeit more verbose approach, it is easier to comprehend to folks new to programming and Playwright. Depending on the team makeup, and the preferences of the folks who will be maintaining and monitoring these tests, I would want to choose the option that the team enjoys the most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently saw this pattern out in the wild and decided to adopt it in this PR to see how it feels.
Using the
withXxxPage(cb)pattern creates a visual block which can help the maintainer more clearly see the scopes of particular pages. It's sort of like#tap do { |p| ... }in Ruby.