Skip to content

Commit

Permalink
module: Don't complain when a module is absent
Browse files Browse the repository at this point in the history
The current implementation depends on a configure-time generated list of
block modules. When any of them is absent, module_load() emits a warning.

This is suboptimal because extracting code to modules was mainly done to
allow separate packaging of modules with intrusive dependencies. Absence
of optional packages then leads to absence of modules and an error
message, which users may recognize as new and report as error.

Cc: Paolo Bonzini <[email protected]>
Cc: Michael Tokarev <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
  • Loading branch information
afaerber authored and bonzini committed Jul 18, 2014
1 parent f9e13f8 commit bb2eb18
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions util/module.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,9 +209,6 @@ static void module_load(module_init_type type)
break;
}
}
if (ret == -ENOENT) {
fprintf(stderr, "Can't find module: %s\n", *mp);
}
}

for (i = 0; i < ARRAY_SIZE(dirs); i++) {
Expand Down

0 comments on commit bb2eb18

Please sign in to comment.