Adds pmd rule BooleanGetMethodName (getodk#1451)

neilong31 · Sep 12, 2017 · 5e9c6dc · 5e9c6dc
1 parent bd62470
commit 5e9c6dc
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/collect_app/src/main/java/org/odk/collect/android/activities/FormEntryActivity.java b/collect_app/src/main/java/org/odk/collect/android/activities/FormEntryActivity.java
@@ -2707,7 +2707,7 @@ public void savingComplete(SaveResult saveResult) {
             case SaveToDiskTask.SAVED_AND_EXIT:
                 ToastUtils.showShortToast(R.string.data_saved_ok);
                 formController.getTimerLogger().logTimerEvent(TimerLogger.EventTypes.FORM_SAVE, 0, null, false, false);
-                if (saveResult.getComplete()) {
+                if (saveResult.isComplete()) {
                     formController.getTimerLogger().logTimerEvent(TimerLogger.EventTypes.FORM_EXIT, 0, null, false, false);
                     formController.getTimerLogger().logTimerEvent(TimerLogger.EventTypes.FORM_FINALIZE, 0, null, false, true);     // Force writing of audit since we are exiting
                 } else {

diff --git a/collect_app/src/main/java/org/odk/collect/android/tasks/SaveResult.java b/collect_app/src/main/java/org/odk/collect/android/tasks/SaveResult.java
@@ -33,7 +33,7 @@ public int getSaveResult() {
         return saveResult;
     }
 
-    public boolean getComplete() {
+    public boolean isComplete() {
         return complete;
     }
 

diff --git a/config/quality/pmd/pmd-ruleset.xml b/config/quality/pmd/pmd-ruleset.xml
@@ -63,6 +63,5 @@
         <exclude name="ShortClassName"/>
         <exclude name="MethodNamingConventions"/>
         <exclude name="AvoidFieldNameMatchingTypeName"/>
-        <exclude name="BooleanGetMethodName"/>
     </rule>
 </ruleset>