Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: Have component_files_identical check for new optional files in modules #2816

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Modules: Have component_files_identical check for new optional files in modules #2816

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
585b1bc
Have component_files_identical check for new optional files in modules
asp8200 Feb 29, 2024
a9cd325
Update nf_core/synced_repo.py
asp8200 Mar 1, 2024
18497c2
Update nf_core/synced_repo.py
asp8200 Mar 1, 2024
c611a35
Update nf_core/synced_repo.py
asp8200 Mar 1, 2024
437ec9e
Update nf_core/synced_repo.py
asp8200 Mar 1, 2024
b72f6cf
Better error msg from fct component_files_identical
asp8200 Mar 1, 2024
0a3a600
No entry in dict files_identical for missing optional files
asp8200 Mar 1, 2024
6311a2c
Merge branch 'dev' into 2774_handle_optional_files
mashehu Mar 1, 2024
80748f3
copy all files when reverting a patch
mashehu Mar 12, 2024
7cebaf6
Merge remote-tracking branch 'mashehu/fix-apply-patch' into 2774_hand…
mirpedrol Mar 12, 2024
d2c00fe
be file agnostic when checking that all component files are identical
mirpedrol Mar 12, 2024
3a4845e
Merge branch 'dev' into 2774_handle_optional_files
asp8200 Mar 15, 2024
bdad0ed
Merge branch 'dev' into 2774_handle_optional_files
asp8200 Mar 15, 2024
848948a
Update nf_core/modules/modules_json.py
asp8200 Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update nf_core/synced_repo.py 
Co-authored-by: Matthias Hörtenhuber <[email protected]>
  • Loading branch information
@asp8200 @mashehu
asp8200 and mashehu authored Mar 1, 2024
commit a9cd3256ff1e7ff71896c7ac6ac504be6a1b8e62
1 change: 0 additions & 1 deletion nf_core/synced_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ def component_files_identical(self, component_name, base_path, commit, component
files_identical[file] = filecmp.cmp(component_file, base_file)
except FileNotFoundError:
errmsg = f"Could not open file: {os.path.join(component_dir, file)}"
log.error(errmsg)
raise UserWarning(errmsg)
self.checkout_branch()
return files_identical
Expand Down
Loading