Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: Have component_files_identical check for new optional files in modules #2816

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Better error msg from fct component_files_identical
  • Loading branch information
asp8200 committed Mar 1, 2024
commit b72f6cf5dc780b44260a20bf5f190b0c8e103cd2
5 changes: 2 additions & 3 deletions nf_core/synced_repo.py
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,8 @@ def component_files_identical(self, component_name, base_path, commit, component
continue
try:
files_identical[file] = filecmp.cmp(component_file, base_file)
mashehu marked this conversation as resolved.
Show resolved Hide resolved
except FileNotFoundError:
errmsg = f"Could not open file: {os.path.join(component_dir, file)}"
raise UserWarning(errmsg)
except FileNotFoundError as e:
raise UserWarning(f"Could not open file: {e.filename}")
self.checkout_branch()
return files_identical

Expand Down