Minor clean-up #122
Minor clean-up #122
Conversation
Prevents garbled output when importing the keyring. Also, no need to install openmediavault-keyring package specifically since it's an openmediavault package dependency.
|
Might as well redirect (>) directly to the file instead of using tee and redirecting the output to /dev/null. |
|
Using tee allows you to add a sudo in front of it for writing permissions for non root users. That's why I kept it. |
|
Just a note that sudo isn't installed by default on a minimal Debian install. |
installation/on_debian.rst
Outdated
| @@ -33,7 +33,7 @@ instructions only partially work. Please refer to a specific `installation scrip | |||
| Install the |omv| keyring manually:: | |||
|
|
|||
| apt-get install --yes gnupg | |||
| wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg" | |||
| wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg" >/dev/null | |||
There was a problem hiding this comment.
| wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg" >/dev/null | |
| wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor --output "/usr/share/keyrings/openmediavault-archive-keyring.gpg" |
There was a problem hiding this comment.
Good one. Does the trick as well, sudo included for gpg this time, be it with the 'old' path ;)
|
Depends on the install config ;) sudo is installed automatically if you install Debian without providing a root password, so root is disabled and the primary user gets sudo privileges. |
|
The --yes flag should be used if --output is used just in case the file exists. |
Nice one too. Including the --yes is consistent with the other command you are using so yeah. What a discussion for just a 'quick' and 'minor' clean-up ;) |
|
Is there anyway I can squash the three commits from the GitHub web UI at this stage? |
I can do that when merging. |
* Minor clean-up Prevents garbled output when importing the keyring. Also, no need to install openmediavault-keyring package specifically since it's an openmediavault package dependency. * Remove tee * Silently approve gpg (cherry picked from commit 24028e2) Signed-off-by: Volker Theile <[email protected]>
Prevents garbled output when importing the keyring:
Also, no need to install openmediavault-keyring package specifically since it's an openmediavault package dependency.