Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean-up #122

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Minor clean-up #122

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35279e9
Minor clean-up
Forage Nov 15, 2023
218d4fc
Remove tee
Forage Nov 15, 2023
b2df687
Silently approve gpg
Forage Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Minor clean-up 
Prevents garbled output when importing the keyring.

Also, no need to install openmediavault-keyring package specifically since it's an openmediavault package dependency.
  • Loading branch information
@Forage
Forage authored Nov 15, 2023
commit 35279e907be40018bd326362b395dd5445de5909
4 changes: 2 additions & 2 deletions installation/on_debian.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ instructions only partially work. Please refer to a specific `installation scrip
Install the |omv| keyring manually::

apt-get install --yes gnupg
wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg"
wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg" >/dev/null
Copy link
Member

@votdev votdev Nov 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor | tee "/usr/share/keyrings/openmediavault-archive-keyring.gpg" >/dev/null
wget --quiet --output-document=- https://packages.openmediavault.org/public/archive.key | gpg --dearmor --output "/usr/share/keyrings/openmediavault-archive-keyring.gpg"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one. Does the trick as well, sudo included for gpg this time, be it with the 'old' path ;)


Add the package repositories::

Expand Down Expand Up @@ -63,7 +63,7 @@ Install the |omv| package::
--no-install-recommends \
--option DPkg::Options::="--force-confdef" \
--option DPkg::Options::="--force-confold" \
install openmediavault-keyring openmediavault
install openmediavault

Populate the |omv| database with several existing system settings, e.g. the network configuration::

Expand Down