Skip to content

Commit

Permalink
iso-crossings: Fix reset polarity in assertions (pulp-platform#129)
Browse files Browse the repository at this point in the history
* iso-crossings: Fix reset polarity in assertions

* changelog: Add changes
paulsc96 authored Feb 14, 2022

Verified

This commit was signed with the committer’s verified signature.
dylanhand Dylan Hand
1 parent 9b7c7df commit 5d112fc
Showing 3 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Unreleased
### Fixed
- Correct reset polarity in assertions in `isochronous_4phase_handshake` and `isochronous_spill_register`

## 1.23.0 - 2021-09-05
### Added
4 changes: 2 additions & 2 deletions src/isochronous_4phase_handshake.sv
Original file line number Diff line number Diff line change
@@ -71,9 +71,9 @@ module isochronous_4phase_handshake (
// pragma translate_off
// stability guarantees
`ifndef VERILATOR
assert property (@(posedge src_clk_i) disable iff (src_rst_ni)
assert property (@(posedge src_clk_i) disable iff (~src_rst_ni)
(src_valid_i && !src_ready_o |=> $stable(src_valid_i))) else $error("src_valid_i is unstable");
assert property (@(posedge dst_clk_i) disable iff (dst_rst_ni)
assert property (@(posedge dst_clk_i) disable iff (~dst_rst_ni)
(dst_valid_o && !dst_ready_i |=> $stable(dst_valid_o))) else $error("dst_valid_o is unstable");
`endif
// pragma translate_on
8 changes: 4 additions & 4 deletions src/isochronous_spill_register.sv
Original file line number Diff line number Diff line change
@@ -98,13 +98,13 @@ module isochronous_spill_register #(
// pragma translate_off
// stability guarantees
`ifndef VERILATOR
assert property (@(posedge src_clk_i) disable iff (src_rst_ni)
assert property (@(posedge src_clk_i) disable iff (~src_rst_ni)
(src_valid_i && !src_ready_o |=> $stable(src_valid_i))) else $error("src_valid_i is unstable");
assert property (@(posedge src_clk_i) disable iff (src_rst_ni)
assert property (@(posedge src_clk_i) disable iff (~src_rst_ni)
(src_valid_i && !src_ready_o |=> $stable(src_data_i))) else $error("src_data_i is unstable");
assert property (@(posedge dst_clk_i) disable iff (dst_rst_ni)
assert property (@(posedge dst_clk_i) disable iff (~dst_rst_ni)
(dst_valid_o && !dst_ready_i |=> $stable(dst_valid_o))) else $error("dst_valid_o is unstable");
assert property (@(posedge dst_clk_i) disable iff (dst_rst_ni)
assert property (@(posedge dst_clk_i) disable iff (~dst_rst_ni)
(dst_valid_o && !dst_ready_i |=> $stable(dst_data_o))) else $error("dst_data_o is unstable");
`endif
// pragma translate_on

0 comments on commit 5d112fc

Please sign in to comment.