Max image width bugfix: Add margin around page containers #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add margin around page container so that the recognized text of one page doesn't run into that of the next page. 1.2em seems like a reasonable amount for readability. Could maybe go slightly higher. I also added some margin on the bottom of the recognized text so it's not too close to the image of the page.
This entry was added in response to philips#22, my question about limiting image width. The entry is no longer relevant because the feature implemented in this branch allows adjusting the image size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #38 by adding margin around page container so that the recognized text of one page doesn't run into that of the next page.
I settled on 1.2em, seems like a reasonable amount for readability, but open to feedback/preferences!
Before this fix:
After this fix:
I also removed an FAQ entry that was added because of my question #22 and is now moot.