Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Donation bugs on dev env #1960

Open
Tuscann opened this issue Oct 15, 2024 · 13 comments · Fixed by #1979
Open

Donation bugs on dev env #1960

Tuscann opened this issue Oct 15, 2024 · 13 comments · Fixed by #1979
Labels
type: bug Something isn't working

Comments

@Tuscann
Copy link

Tuscann commented Oct 15, 2024

Which area(s) of Podkrepi.bg are affected?

Desktop layout

Describe the Bug

Bugs

Steps to Reproduce

  1. Change placeholder [email protected] to:
    Email address
    Your email
    Email
    image

  2. Why empty fields are not red (Not fixed)
    image

  3. Why is possible to make empty donation without any money ? (Not fixed)
    3.1. Do not select money for donate or choose Other amount
    3.2. Select One time for How often would you want to donate
    3.3. Select bank transfer
    3.4. Select Continue without registration
    3.5. Click checkbox I understand and I agree to the [General Data Protection Regulation (GDPR)]
    (https://dev.podkrepi.bg/en/privacy-policy)
    3.6. Click Donate button

    In case that bank transfer is chosen is better to disable donation part (How much would you like to donate?).
    Why user can choose to donate 100 000 leva in UI but to send only by bank 10 leva? Need discussion.
    How user to understand that donation part is disable in UI?

      Example:
    

    170.1 Select BGN 10.00
    170.2 Choose Bank transfer
    170.3 User want to change to BGN20.00 but field is locked not good practice

  4. Fix dot for end of sentance.
    image

  5. What is Имахте предвид @abv.be?
    image

  6. Why is possible to make donation when is not clicked button Log in

https://youtu.be/ZX_zJIHIWU8

  1. Why after refresh of page with F5 fields are still selected?
    Return to campaigns and open same campaign fields are still selected.

  2. On mobile view add some distance between texts
    image

Expected Behavior

Fix bugs

Which browser are you using? (if relevant)

Chrome last stable version

@Tuscann Tuscann added the type: bug Something isn't working label Oct 15, 2024
@nikolay-yankov
Copy link
Contributor

Hey @Tuscann 👋 How did you reproduce issue #3? I tried by hitting the Donate button without filling any fields in the form, but such a green check doesn't appear and I wonder how to reproduce it. Tried locally and on dev.podkrepi.bg with Chrome.

@swolf86
Copy link

swolf86 commented Oct 19, 2024

![Screenshot_2024-10-19-22-39-15-03_4b14b257287ac0a6d1fd5fbb

Text distance is too small apply at least 30px below and above the tick box

Screenshot_2024-10-19-22-41-20-49_4641ebc0df1485bf6b47ebd018b5ee76

Tooltip (I) doesn't activate on a single click on a mobile
Screenshot_2024-10-19-22-39-15-03_4b14b257287ac0a6d1fd5fbb2487716f

@nikolay-yankov
Copy link
Contributor

I think Fees message should not be displayed if Amount is not selected as it displays negative numbers

Steps

  1. Go to donation page in BG version
  2. Select Card Payment

Result

Displays a message with negative number: кампанията ще получи -0,50 лв.

Suggestion

Do not show this message if Amount is not selected

image
image

Steps

  1. Switch to EN version

Result

Displays another message with negative number: For your donation of -BGN 0.50,

image

@Tuscann
Copy link
Author

Tuscann commented Oct 20, 2024

Hey @Tuscann 👋 How did you reproduce issue #3? I tried by hitting the Donate button without filling any fields in the form, but such a green check doesn't appear and I wonder how to reproduce it. Tried locally and on dev.podkrepi.bg with Chrome.

Normally I am using Vivaldi as main Browser. I cannot reproduce this bug now. When click F5 to refresh the page these two green ticks are shown for short period of time. If find a way to reproduced, I will write here.

@sashko9807
Copy link
Member

sashko9807 commented Dec 4, 2024

  1. Appears to be working correctly? Though the PR from above should solve an issue which causes to show 2 error messages, for the same field fix: Donation flow more fixes #1989.
  2. Stripe doesn't send invoice emails in Test environment(which is used for staging). Expected behavior, not a bug(until confirmed in production).
  3. Should be fixed with fix: Donation flow more fixes #1989
  4. Should be fixed with fix: Donation flow more fixes #1989
  5. Opens the correct URL. The page itself is not translated
  6. Unable to reproduce anymore.
  7. Should be fixed with fix: Donation flow more fixes #1989
  8. Should be fixed with fix: Donation flow more fixes #1989
  9. Should be fixed with fix: Donation flow more fixes #1989
  10. Not a bug. Technically when selecting Bank transfer option, the Amount field is disabled too, as we can't know for certain what amount will be sent through the bank.
  11. Should be fixed with fix: Donation flow more fixes #1989

@Tuscann
Copy link
Author

Tuscann commented Dec 5, 2024

  1. Appears to be working correctly? Though the PR from above should solve an issue which causes to show 2 error messages, for the same field fix: Donation flow more fixes #1989.
  2. Stripe doesn't send invoice emails in Test environment(which is used for staging). Expected behavior, not a bug(until confirmed in production).
  3. Should be fixed with fix: Donation flow more fixes #1989
  4. Should be fixed with fix: Donation flow more fixes #1989
  5. Opens the correct URL. The page itself is not translated
  6. Unable to reproduce anymore.
  7. Should be fixed with fix: Donation flow more fixes #1989
  8. Should be fixed with fix: Donation flow more fixes #1989
  9. Should be fixed with fix: Donation flow more fixes #1989
  10. Not a bug. Technically when selecting Bank transfer option, the Amount field is disabled too, as we can't know for certain what amount will be sent through the bank.
  11. Should be fixed with fix: Donation flow more fixes #1989

@sashko9807 Tag me here when this ticket is deployed on dev2 env and ready for test.

@sashko9807
Copy link
Member

@Tuscann the latest batch of fixes is deployed, and ready for testing

@Tuscann
Copy link
Author

Tuscann commented Dec 6, 2024

@sashko9807
Retested all old bugs. Removed fixed ones. Added new bugs.
Please tag me when fix all bugs :)

@sashko9807
Copy link
Member

Would you try to go through the straight flow without the autocomplete extension? I tried 1,2 as shown in the video but my donation are passing from first time. Also what is the name of the extension?

@Tuscann
Copy link
Author

Tuscann commented Dec 6, 2024

Would you try to go through the straight flow without the autocomplete extension? I tried 1,2 as shown in the video but my donation are passing from first time. Also what is the name of the extension?

This is video for bug 12 (https://youtu.be/dTTcYBzPJtY) with Incognito mode of Chrome Version 131.0.6778.108 (Official Build) (64-bit) without any extenstions.
I am using plenty of extensions but this is not problem here.

If you have any questions about bugs you can not reproduce I will make video.

@sashko9807
Copy link
Member

sashko9807 commented Dec 6, 2024

Would you try to go through the straight flow without the autocomplete extension? I tried 1,2 as shown in the video but my donation are passing from first time. Also what is the name of the extension?

This is video for bug 12 (https://youtu.be/dTTcYBzPJtY) with Incognito mode of Chrome Version 131.0.6778.108 (Official Build) (64-bit) without any extenstions. I am using plenty of extensions but this is not problem here.

If you have any questions about bugs you can not reproduce I will make video.

Issue 12 is not exactly a bug. Its a suggestion coming from Stripe.
Should be solved when we start to save reference data regarding a bank donation, as the idea is to no longer use Stripe field to retrieve the email.

I am mostly interested at issues 1 2 and 3 as I am unable to reproduce them. The issue is neither the checked Anonymous donation, or registration unchecked checkbox fields, or otherAmount as by default it gets value of 1(that can be confirmed by looking at the stripe fee sentence), and the only reason I can think of is some conflict with browser extension.

@Tuscann
Copy link
Author

Tuscann commented Dec 7, 2024

Would you try to go through the straight flow without the autocomplete extension? I tried 1,2 as shown in the video but my donation are passing from first time. Also what is the name of the extension?

This is video for bug 12 (https://youtu.be/dTTcYBzPJtY) with Incognito mode of Chrome Version 131.0.6778.108 (Official Build) (64-bit) without any extenstions. I am using plenty of extensions but this is not problem here.
If you have any questions about bugs you can not reproduce I will make video.

Issue 12 is not exactly a bug. Its a suggestion coming from Stripe. Should be solved when we start to save reference data regarding a bank donation, as the idea is to no longer use Stripe field to retrieve the email.

I am mostly interested at issues 1 2 and 3 as I am unable to reproduce them. The issue is neither the checked Anonymous donation, or registration unchecked checkbox fields, or otherAmount as by default it gets value of 1(that can be confirmed by looking at the stripe fee sentence), and the only reason I can think of is some conflict with browser extension.

Check videos made with Incognito mode of Chrome Version 131.0.6778.108 (Official Build) (64-bit) without any extenstions.

https://youtu.be/Ji2Hh6zISIs - 401
https://youtu.be/aMALm3MAC90 - 400

@sashko9807
Copy link
Member

@Tuscann the latest batch of fixes, is deployed on stage. Could you please test again if the bugs from above have been addressed?
The email hint, and the disabled amount state can be ignored for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants